From fbc09d5780bff246795e58812fa6881a28d04a10 Mon Sep 17 00:00:00 2001 From: Alex Kost Date: Thu, 26 Jul 2018 22:08:42 +0300 Subject: Fix "Builds" buttons in Build Info buffer This is a followup to commit c9a3501ef48092d99ad8ae3680752c3db2201c0f. These "Builds" buttons are intended to be specialized (to search only for builds by project, system, etc.). Instead they all were made the same. * build-farm-build.el (build-farm-build-info-insert-button): Remove. (build-farm-build-info-insert-project, build-farm-build-info-insert-jobset) (build-farm-build-info-insert-job, build-farm-build-info-insert-system): Use 'build-farm-build-info-insert-builds-button' instead (with the appropriate arguments). --- build-farm-build.el | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/build-farm-build.el b/build-farm-build.el index 5937583..17d7584 100644 --- a/build-farm-build.el +++ b/build-farm-build.el @@ -279,38 +279,37 @@ See `build-farm-build-status-alist'." 'job job 'system system)) -(defun build-farm-build-info-insert-button (entry) - "Insert 'Builds' button for build ENTRY at point." - (build-farm-build-info-insert-builds-button - :project (bui-entry-non-void-value entry 'project) - :jobset (bui-entry-non-void-value entry 'jobset) - :job (bui-entry-non-void-value entry 'job) - :system (bui-entry-non-void-value entry 'system))) - (defun build-farm-build-info-insert-project (project entry) "Insert PROJECT for build ENTRY at point." (bui-insert-button project 'build-farm-project) (bui-insert-indent) - (build-farm-build-info-insert-button entry)) + (build-farm-build-info-insert-builds-button + :project (bui-entry-non-void-value entry 'project))) (defun build-farm-build-info-insert-jobset (jobset entry) "Insert JOBSET for build ENTRY at point." (build-farm-info-insert-jobset (bui-entry-non-void-value entry 'project) jobset) (bui-insert-indent) - (build-farm-build-info-insert-button entry)) + (build-farm-build-info-insert-builds-button + :project (bui-entry-non-void-value entry 'project) + :jobset (bui-entry-non-void-value entry 'jobset))) (defun build-farm-build-info-insert-job (job entry) "Insert JOB for build ENTRY at point." (bui-format-insert job 'build-farm-info-job) (bui-insert-indent) - (build-farm-build-info-insert-button entry)) + (build-farm-build-info-insert-builds-button + :project (bui-entry-non-void-value entry 'project) + :jobset (bui-entry-non-void-value entry 'jobset) + :job (bui-entry-non-void-value entry 'job))) (defun build-farm-build-info-insert-system (system entry) "Insert SYSTEM for build ENTRY at point." (bui-format-insert system 'build-farm-info-system) (bui-insert-indent) - (build-farm-build-info-insert-button entry)) + (build-farm-build-info-insert-builds-button + :system (bui-entry-non-void-value entry 'system))) (defun build-farm-build-info-insert-url (entry) "Insert URL for the build ENTRY." -- cgit v1.2.3