From d5380843c63b84e550bf3cd33c70bbf626743c67 Mon Sep 17 00:00:00 2001 From: "Artyom V. Poptsov" Date: Sun, 9 Oct 2016 18:22:13 +0300 Subject: libguile-ssh: Bugfix: Fix SMOB freeing callbacks MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The SMOB freeing callbacks would always fail to free any resources due to mistaken use of 'SCM_SMOB_PREDICATE' procedure -- the procedure doesn't work in these GC callbacks according to the documentation (see '(guile) Smobs') and always returns 'false' as the result when used in such context. The solution is to remove the check 'SCM_SMOB_PREDICATE' and just get the SMOB's data. Reported by: David Kastrup Reported by: Ludovic Courtès * libguile-ssh/key-type.c, libguile-ssh/message-type.c, libguile-ssh/server-type.c, libguile-ssh/session-type.c, libguile-ssh/sftp-session-type.c: Bugfix: Fix SMOB freeing callbacks. * NEWS: Update. --- NEWS | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'NEWS') diff --git a/NEWS b/NEWS index 4f315d3..41ce39b 100644 --- a/NEWS +++ b/NEWS @@ -7,6 +7,13 @@ Copyright (C) Artyom V. Poptsov are permitted in any medium without royalty provided the copyright notice and this notice are preserved. +* Unreleased +** Bugfixes +*** Fix SMOB freeing callbacks + Callbacks for many Guile-SSH objects would always fail to free allocated + resources due to wrong check added in 0.10.0. The problem should be fixed + now. + * Changes in version 0.10.0 (2016-08-20) ** Add support of Guile 2.0.12 Guile-SSH now builds (and works quite well, as far as I can see) with Guile -- cgit v1.2.3