summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Weinelt <mweinelt@users.noreply.github.com>2021-12-17 00:55:07 +0100
committerGitHub <noreply@github.com>2021-12-17 00:55:07 +0100
commitcf92ba460c5aa3947052ccfc51c488632180c785 (patch)
tree0dc8a98296455abc8fd20a8dd1e30c65c11f4012
parentMerge pull request #151012 from NixOS/backport-150614-to-release-21.11 (diff)
parentnixos/snapserver: use the correct bind address arguments (diff)
downloadnixpkgs-cf92ba460c5aa3947052ccfc51c488632180c785.tar.gz
Merge pull request #151033 from NixOS/backport-151029-to-release-21.11
-rw-r--r--nixos/modules/services/audio/snapserver.nix4
-rw-r--r--nixos/tests/snapcast.nix8
2 files changed, 10 insertions, 2 deletions
diff --git a/nixos/modules/services/audio/snapserver.nix b/nixos/modules/services/audio/snapserver.nix
index d3e97719f357..b82aca3976f0 100644
--- a/nixos/modules/services/audio/snapserver.nix
+++ b/nixos/modules/services/audio/snapserver.nix
@@ -54,12 +54,12 @@ let
# tcp json rpc
++ [ "--tcp.enabled ${toString cfg.tcp.enable}" ]
++ optionals cfg.tcp.enable [
- "--tcp.address ${cfg.tcp.listenAddress}"
+ "--tcp.bind_to_address ${cfg.tcp.listenAddress}"
"--tcp.port ${toString cfg.tcp.port}" ]
# http json rpc
++ [ "--http.enabled ${toString cfg.http.enable}" ]
++ optionals cfg.http.enable [
- "--http.address ${cfg.http.listenAddress}"
+ "--http.bind_to_address ${cfg.http.listenAddress}"
"--http.port ${toString cfg.http.port}"
] ++ optional (cfg.http.docRoot != null) "--http.doc_root \"${toString cfg.http.docRoot}\"");
diff --git a/nixos/tests/snapcast.nix b/nixos/tests/snapcast.nix
index 8d960b4cc069..30b8343e2ffe 100644
--- a/nixos/tests/snapcast.nix
+++ b/nixos/tests/snapcast.nix
@@ -40,6 +40,7 @@ in {
};
};
};
+ environment.systemPackages = [ pkgs.snapcast ];
};
client = {
environment.systemPackages = [ pkgs.snapcast ];
@@ -71,6 +72,13 @@ in {
"curl --fail http://localhost:${toString httpPort}/jsonrpc -d '{json.dumps(get_rpc_version)}'"
)
+ with subtest("test a ipv6 connection"):
+ server.execute("systemd-run --unit=snapcast-local-client snapclient -h ::1 -p ${toString port}")
+ server.wait_until_succeeds(
+ "journalctl -o cat -u snapserver.service | grep -q 'Hello from'"
+ )
+ server.wait_until_succeeds("journalctl -o cat -u snapcast-local-client | grep -q 'buffer: ${toString bufferSize}'")
+
with subtest("test a connection"):
client.execute("systemd-run --unit=snapcast-client snapclient -h server -p ${toString port}")
server.wait_until_succeeds(