summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPol Dellaiera <pol.dellaiera@protonmail.com>2025-05-31 21:08:53 +0000
committerGitHub <noreply@github.com>2025-05-31 21:08:53 +0000
commit03cb8b011a9fc95fb743811b513ee365574f6040 (patch)
tree06e12d3a0e61d1c441509bbd70ee4523020f0ca2
parentiosevka: 33.2.3 -> 33.2.4 (#412754) (diff)
parentudevCheckHook: remove broken cross-compilation check (diff)
downloadnixpkgs-03cb8b011a9fc95fb743811b513ee365574f6040.tar.gz
udevCheckHook: remove broken cross-compilation check (#412708)
-rw-r--r--pkgs/by-name/ud/udevCheckHook/package.nix11
1 files changed, 6 insertions, 5 deletions
diff --git a/pkgs/by-name/ud/udevCheckHook/package.nix b/pkgs/by-name/ud/udevCheckHook/package.nix
index 261a503595ea..681b5d5f7a06 100644
--- a/pkgs/by-name/ud/udevCheckHook/package.nix
+++ b/pkgs/by-name/ud/udevCheckHook/package.nix
@@ -2,15 +2,16 @@
lib,
makeSetupHook,
systemdMinimal,
- udev,
stdenv,
}:
let
# udev rules can only be checked if systemd (specifically, 'udevadm') can be executed on build platform
- # if udev is not available on hostPlatform, there is no point in checking rules
- applyHook =
- lib.meta.availableOn stdenv.hostPlatform udev
- && lib.meta.availableOn stdenv.buildPlatform systemdMinimal;
+ # If cross-compiling linux -> non-linux, udev rules are still checked, even if they end up being unused.
+ # This is not a problem:
+ # - If there are no udev rules, the hook is a noop
+ # - If the udev rules are broken, they should be flagged as such
+ # - if rules are not needed on a target platform where they are broken, they should be deleted from package output
+ applyHook = lib.meta.availableOn stdenv.buildPlatform systemdMinimal;
in
makeSetupHook {
name = "udev-check-hook";