diff options
| author | Emily <vcs@emily.moe> | 2024-11-07 01:20:18 +0000 |
|---|---|---|
| committer | Emily <vcs@emily.moe> | 2024-11-07 23:05:27 +0000 |
| commit | 88f3513dbf7a107657d7bf69c1f9d1f7fca7414e (patch) | |
| tree | 01ef745d4902f262e7579e24e7f423f36ec3da43 | |
| parent | [llvm-19] rust: use LLVM 19 (#354149) (diff) | |
| download | nixpkgs-88f3513dbf7a107657d7bf69c1f9d1f7fca7414e.tar.gz | |
buildMozillaMach: apply upstream WASI SDK workaround for LLVM 19
I have no idea why this is necessary for us and why the upstream patch
doesn’t work, but this gets the Mozilla packages building on LLVM
19 in the meantime while we try to figure that out.
Closes: #352724
| -rw-r--r-- | pkgs/applications/networking/browsers/firefox/common.nix | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/pkgs/applications/networking/browsers/firefox/common.nix b/pkgs/applications/networking/browsers/firefox/common.nix index dc52606f24b7..be1a1fbadb97 100644 --- a/pkgs/applications/networking/browsers/firefox/common.nix +++ b/pkgs/applications/networking/browsers/firefox/common.nix @@ -254,6 +254,25 @@ buildStdenv.mkDerivation { hash = "sha256-2IpdSyye3VT4VB95WurnyRFtdN1lfVtYpgEiUVhfNjw="; }) ] + ++ [ + # LLVM 19 turned on WASM reference types by default, exposing a bug + # that broke the Mozilla WASI build. Supposedly, it has been fixed + # upstream in LLVM, but the build fails in the same way for us even + # with LLVM 19 versions that contain the upstream patch. + # + # Apply the temporary patch Mozilla used to work around this bug + # for now until someone can investigate what’s going on here. + # + # TODO: Please someone figure out what’s up with this. + # + # See: <https://bugzilla.mozilla.org/show_bug.cgi?id=1905251> + # See: <https://github.com/llvm/llvm-project/pull/97451> + (fetchpatch { + name = "wasi-sdk-disable-reference-types.patch"; + url = "https://hg.mozilla.org/integration/autoland/raw-rev/23a9f6555c7c"; + hash = "sha256-CRywalJlRMFVLITEYXxpSq3jLPbUlWKNRHuKLwXqQfU="; + }) + ] ++ extraPatches; postPatch = '' |