diff options
| author | Kamran Ahmed <kamranahmed.se@gmail.com> | 2018-08-28 11:25:36 +0500 |
|---|---|---|
| committer | Kamran Ahmed <kamranahmed.se@gmail.com> | 2018-08-28 11:25:36 +0500 |
| commit | 64a8091a530157abcdd8c72f42e08f440ecbed8d (patch) | |
| tree | fde4be8115bbfa3b593d3a691c93442116c15687 /src | |
| parent | Change of date headings (diff) | |
| download | githunt-64a8091a530157abcdd8c72f42e08f440ecbed8d.tar.gz | |
Fix linter issues and UI
Diffstat (limited to 'src')
| -rw-r--r-- | src/components/filters/view-filter/index.js | 8 | ||||
| -rw-r--r-- | src/components/filters/view-filter/styles.css | 15 | ||||
| -rw-r--r-- | src/components/group-heading/index.js | 8 | ||||
| -rw-r--r-- | src/components/launcher/index.js | 2 | ||||
| -rw-r--r-- | src/components/repository-grid/grid-item/index.js | 2 | ||||
| -rw-r--r-- | src/components/repository-list/list-item/index.js | 2 | ||||
| -rw-r--r-- | src/components/top-nav/index.js | 5 |
7 files changed, 25 insertions, 17 deletions
diff --git a/src/components/filters/view-filter/index.js b/src/components/filters/view-filter/index.js index 1d21266..ab8b033 100644 --- a/src/components/filters/view-filter/index.js +++ b/src/components/filters/view-filter/index.js @@ -15,14 +15,14 @@ class ViewFilter extends React.Component { return ( <div className="view-type-wrap"> <div className="view-type btn shadowed cursor-default"> - <a onClick={ () => this.changeSelected('grid') } href="javascript:void(0)" className={ classNames({ active: this.props.selectedViewType === 'grid' }) }> + <button onClick={ () => this.changeSelected('grid') } className={ classNames({ active: this.props.selectedViewType === 'grid' }) }> <i className="fa fa-table mr-2"></i> Grid - </a> - <a onClick={ () => this.changeSelected('list') } href="javascript:void(0)" className={ classNames({ active: this.props.selectedViewType === 'list' }) }> + </button> + <button onClick={ () => this.changeSelected('list') } className={ classNames({ active: this.props.selectedViewType === 'list' }) }> <i className="fa fa-list mr-2"></i> List - </a> + </button> </div> </div> ); diff --git a/src/components/filters/view-filter/styles.css b/src/components/filters/view-filter/styles.css index af3cd97..6984ffb 100644 --- a/src/components/filters/view-filter/styles.css +++ b/src/components/filters/view-filter/styles.css @@ -5,16 +5,23 @@ cursor: default; } -.view-type a { +.view-type button { color: #ccc; - margin-left: 20px; text-decoration: none; + margin: 0 0 0 20px; + list-style: none; + border: none; + background: none; + cursor: pointer; + -webkit-appearance: none; + box-shadow: none; + outline: none; } -.view-type a.active, .view-type a:hover { +.view-type button.active, .view-type button:hover { color: #343a40; } -.view-type a:first-child { +.view-type button:first-child { margin-left: 0; } diff --git a/src/components/group-heading/index.js b/src/components/group-heading/index.js index cca5c03..b9f5006 100644 --- a/src/components/group-heading/index.js +++ b/src/components/group-heading/index.js @@ -24,11 +24,11 @@ class GroupHeading extends React.Component { // Return the relative date const formattedDate = startMoment.fromNow(); if (formattedDate === 'a year ago') { - return 'Last Year'; - } else if (formattedDate === 'a month ago') { - return 'This Month'; + return 'Last year'; } else if (formattedDate === '6 days ago') { - return 'This Week'; + return 'This week'; + } else if (formattedDate === '13 days ago') { + return 'Last week'; } return formattedDate; diff --git a/src/components/launcher/index.js b/src/components/launcher/index.js index 1d4d6d0..c723fcd 100644 --- a/src/components/launcher/index.js +++ b/src/components/launcher/index.js @@ -5,7 +5,7 @@ import './styles.css'; const Launcher = () => ( <div className="launcher-body"> <div className="logo-container"> - <img src='/img/logo.svg'/> + <img src='/img/logo.svg' alt='GitHunt'/> <div className="logo-text"> <h4>Loading ..</h4> <p className="text-muted">We're testing your patience</p> diff --git a/src/components/repository-grid/grid-item/index.js b/src/components/repository-grid/grid-item/index.js index b77ebac..571e5ea 100644 --- a/src/components/repository-grid/grid-item/index.js +++ b/src/components/repository-grid/grid-item/index.js @@ -15,7 +15,7 @@ class GridItem extends React.Component { <div className="author-header clearfix"> <a href={ this.props.repository.owner.html_url } target="_blank"> <div className="author-img"> - <img src={ this.props.repository.owner.avatar_url }/> + <img src={ this.props.repository.owner.avatar_url } alt={ this.props.repository.owner.login }/> </div> <div className="author-details"> <h5>{ this.props.repository.owner.login }</h5> diff --git a/src/components/repository-list/list-item/index.js b/src/components/repository-list/list-item/index.js index dd8cf0a..f4429bd 100644 --- a/src/components/repository-list/list-item/index.js +++ b/src/components/repository-list/list-item/index.js @@ -59,7 +59,7 @@ class ListItem extends React.Component { <a href={ this.props.repository.owner.html_url } target="_blank" className="author-link d-none d-lg-block d-xl-block d-md-block"> - <img className='author-img' src={ this.props.repository.owner.avatar_url }/> + <img className='author-img' src={ this.props.repository.owner.avatar_url } alt={ this.props.repository.owner.login }/> </a> </div> ); diff --git a/src/components/top-nav/index.js b/src/components/top-nav/index.js index 3480ea7..365e481 100644 --- a/src/components/top-nav/index.js +++ b/src/components/top-nav/index.js @@ -1,6 +1,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import classNames from 'classnames'; +import { Link } from 'react-router-dom'; import './styles.css'; import Logo from '../icons/logo'; @@ -8,13 +9,13 @@ import Logo from '../icons/logo'; const TopNav = (props) => ( <div className='top-nav'> <div className="container clearfix"> - <a href='/' className="logo clearfix float-left"> + <Link to="/" className="logo clearfix float-left"> <Logo/> <div className="logo-text"> <h4>GitHunt</h4> <p className="text-muted">Most starred projects on GitHub</p> </div> - </a> + </Link> <div className="float-right duration-btns"> <button onClick={ () => props.updateDateJump('year') } className={ |
