Merge pull request #3297 from hainesc/type_check

Add type check for each implementation of Module interface

18 files changed, 36 insertions, 0 deletions

diff --git a/cloud/pkg/cloudhub/cloudhub.go b/cloud/pkg/cloudhub/cloudhub.go
index 37a64fa7b..6d73ec543 100644
--- a/cloud/pkg/cloudhub/cloudhub.go
+++ b/cloud/pkg/cloudhub/cloudhub.go
@@ -26,6 +26,8 @@ type cloudHub struct {
 	messageq             *channelq.ChannelMessageQueue
 }
 
+var _ core.Module = (*cloudHub)(nil)
+
 func newCloudHub(enable bool) *cloudHub {
 	crdFactory := informers.GetInformersManager().GetCRDInformerFactory()
 	// declare used informer
diff --git a/cloud/pkg/cloudstream/cloudstream.go b/cloud/pkg/cloudstream/cloudstream.go
index bddede12b..7f3943815 100644
--- a/cloud/pkg/cloudstream/cloudstream.go
+++ b/cloud/pkg/cloudstream/cloudstream.go
@@ -28,6 +28,8 @@ type cloudStream struct {
 	enable bool
 }
 
+var _ core.Module = (*cloudStream)(nil)
+
 func newCloudStream(enable bool) *cloudStream {
 	return &cloudStream{
 		enable: enable,
diff --git a/cloud/pkg/devicecontroller/devicecontroller.go b/cloud/pkg/devicecontroller/devicecontroller.go
index fd7bfbd4d..42f8d1261 100644
--- a/cloud/pkg/devicecontroller/devicecontroller.go
+++ b/cloud/pkg/devicecontroller/devicecontroller.go
@@ -20,6 +20,8 @@ type DeviceController struct {
 	enable     bool
 }
 
+var _ core.Module = (*DeviceController)(nil)
+
 func newDeviceController(enable bool) *DeviceController {
 	if !enable {
 		return &DeviceController{enable: enable}
diff --git a/cloud/pkg/dynamiccontroller/dynamiccontroller.go b/cloud/pkg/dynamiccontroller/dynamiccontroller.go
index 62a94eee7..4d158c8e5 100644
--- a/cloud/pkg/dynamiccontroller/dynamiccontroller.go
+++ b/cloud/pkg/dynamiccontroller/dynamiccontroller.go
@@ -38,6 +38,8 @@ type DynamicController struct {
 	applicationCenter            *application.Center
 }
 
+var _ core.Module = (*DynamicController)(nil)
+
 func Register(dc *configv1alpha1.DynamicController) {
 	config.InitConfigure(dc)
 	core.Register(newDynamicController(dc.Enable))
diff --git a/cloud/pkg/edgecontroller/edgecontroller.go b/cloud/pkg/edgecontroller/edgecontroller.go
index de713045f..0ae74869a 100644
--- a/cloud/pkg/edgecontroller/edgecontroller.go
+++ b/cloud/pkg/edgecontroller/edgecontroller.go
@@ -17,6 +17,8 @@ type EdgeController struct {
 	downstream *controller.DownstreamController
 }
 
+var _ core.Module = (*EdgeController)(nil)
+
 func newEdgeController(config *v1alpha1.EdgeController, tunnelPort int) *EdgeController {
 	ec := &EdgeController{config: *config}
 	if !ec.Enable() {
diff --git a/cloud/pkg/router/router.go b/cloud/pkg/router/router.go
index f3d391c49..79d42894c 100644
--- a/cloud/pkg/router/router.go
+++ b/cloud/pkg/router/router.go
@@ -26,6 +26,8 @@ type router struct {
 	enable bool
 }
 
+var _ core.Module = (*router)(nil)
+
 func newRouter(enable bool) *router {
 	return &router{
 		enable: enable,
diff --git a/cloud/pkg/synccontroller/synccontroller.go b/cloud/pkg/synccontroller/synccontroller.go
index 6a68ed39d..7cbcd03d4 100644
--- a/cloud/pkg/synccontroller/synccontroller.go
+++ b/cloud/pkg/synccontroller/synccontroller.go
@@ -41,6 +41,8 @@ type SyncController struct {
 	informersSyncedFuncs []cache.InformerSynced
 }
 
+var _ core.Module = (*SyncController)(nil)
+
 func newSyncController(enable bool) *SyncController {
 	var sctl = &SyncController{
 		enable:     enable,
diff --git a/edge/pkg/devicetwin/devicetwin.go b/edge/pkg/devicetwin/devicetwin.go
index 0a89071c6..333c12c26 100644
--- a/edge/pkg/devicetwin/devicetwin.go
+++ b/edge/pkg/devicetwin/devicetwin.go
@@ -20,6 +20,8 @@ type DeviceTwin struct {
 	enable            bool
 }
 
+var _ core.Module = (*DeviceTwin)(nil)
+
 func newDeviceTwin(enable bool) *DeviceTwin {
 	return &DeviceTwin{
 		HeartBeatToModule: make(map[string]chan interface{}),
diff --git a/edge/pkg/edged/edged.go b/edge/pkg/edged/edged.go
index d6c166db0..5cf4ef36e 100644
--- a/edge/pkg/edged/edged.go
+++ b/edge/pkg/edged/edged.go
@@ -262,6 +262,8 @@ type edged struct {
 	podKiller PodKiller
 }
 
+var _ core.Module = (*edged)(nil)
+
 // Register register edged
 func Register(e *v1alpha1.Edged) {
 	edgedconfig.InitConfigure(e)
diff --git a/edge/pkg/edgehub/edgehub.go b/edge/pkg/edgehub/edgehub.go
index 3abc9dc5b..228d85cf2 100644
--- a/edge/pkg/edgehub/edgehub.go
+++ b/edge/pkg/edgehub/edgehub.go
@@ -26,6 +26,8 @@ type EdgeHub struct {
 	enable        bool
 }
 
+var _ core.Module = (*EdgeHub)(nil)
+
 func newEdgeHub(enable bool) *EdgeHub {
 	return &EdgeHub{
 		reconnectChan: make(chan struct{}),
diff --git a/edge/pkg/edgestream/edgestream.go b/edge/pkg/edgestream/edgestream.go
index 29cb78016..39e03ba8f 100644
--- a/edge/pkg/edgestream/edgestream.go
+++ b/edge/pkg/edgestream/edgestream.go
@@ -40,6 +40,8 @@ type edgestream struct {
 	nodeIP           string
 }
 
+var _ core.Module = (*edgestream)(nil)
+
 func newEdgeStream(enable bool, hostnameOverride, nodeIP string) *edgestream {
 	return &edgestream{
 		enable:           enable,
diff --git a/edge/pkg/eventbus/eventbus.go b/edge/pkg/eventbus/eventbus.go
index 944b3f986..960d26641 100644
--- a/edge/pkg/eventbus/eventbus.go
+++ b/edge/pkg/eventbus/eventbus.go
@@ -26,6 +26,8 @@ type eventbus struct {
 	enable bool
 }
 
+var _ core.Module = (*eventbus)(nil)
+
 func newEventbus(enable bool) *eventbus {
 	return &eventbus{
 		enable: enable,
diff --git a/edge/pkg/metamanager/metamanager.go b/edge/pkg/metamanager/metamanager.go
index 157fdd13c..ef0e14052 100644
--- a/edge/pkg/metamanager/metamanager.go
+++ b/edge/pkg/metamanager/metamanager.go
@@ -28,6 +28,8 @@ type metaManager struct {
 	enable bool
 }
 
+var _ core.Module = (*metaManager)(nil)
+
 func newMetaManager(enable bool) *metaManager {
 	return &metaManager{enable: enable}
 }
diff --git a/edge/pkg/servicebus/servicebus.go b/edge/pkg/servicebus/servicebus.go
index 6678f6fda..bd51c7ae6 100644
--- a/edge/pkg/servicebus/servicebus.go
+++ b/edge/pkg/servicebus/servicebus.go
@@ -30,6 +30,8 @@ type servicebus struct {
 	enable bool
 }
 
+var _ core.Module = (*servicebus)(nil)
+
 var htc = new(http.Client)
 var uc = new(util.URLClient)
 
diff --git a/edge/test/cloudhub/stub.go b/edge/test/cloudhub/stub.go
index dec21dd85..1fb44cda0 100644
--- a/edge/test/cloudhub/stub.go
+++ b/edge/test/cloudhub/stub.go
@@ -31,6 +31,8 @@ type stubCloudHub struct {
 	enable bool
 }
 
+var _ core.Module = (*stubCloudHub)(nil)
+
 func (*stubCloudHub) Name() string {
 	return "stubCloudHub"
 }
diff --git a/edge/test/test.go b/edge/test/test.go
index 234901aa4..5941a225d 100644
--- a/edge/test/test.go
+++ b/edge/test/test.go
@@ -33,6 +33,8 @@ type testManager struct {
 	enable bool
 }
 
+var _ core.Module = (*testManager)(nil)
+
 func (tm *testManager) Name() string {
 	return name
 }
diff --git a/tests/stubs/cloud/controllerstub/module.go b/tests/stubs/cloud/controllerstub/module.go
index 1e3c419fe..89077addd 100644
--- a/tests/stubs/cloud/controllerstub/module.go
+++ b/tests/stubs/cloud/controllerstub/module.go
@@ -34,6 +34,8 @@ func init() {
 type ControllerStub struct {
 }
 
+var _ core.Module = (*ControllerStub)(nil)
+
 func (*ControllerStub) Enable() bool {
 	return true
 }
diff --git a/tests/stubs/edge/handlerstub/module.go b/tests/stubs/edge/handlerstub/module.go
index 728699483..f559809eb 100644
--- a/tests/stubs/edge/handlerstub/module.go
+++ b/tests/stubs/edge/handlerstub/module.go
@@ -33,6 +33,8 @@ type HandlerStub struct {
 	podManager *PodManager
 }
 
+var _ core.Module = (*HandlerStub)(nil)
+
 func (*HandlerStub) Enable() bool {
 	return true
 }