diff options
| author | Dmitry Kalinkin <dmitry.kalinkin@gmail.com> | 2020-02-24 03:30:16 -0500 |
|---|---|---|
| committer | Dmitry Kalinkin <dmitry.kalinkin@gmail.com> | 2020-03-03 12:51:50 -0500 |
| commit | 899cf4ba29271b629cd621a421922ed2cb7eefc2 (patch) | |
| tree | 073e87f76c230813525618770baf7d370374aee8 /pkgs/development/python-modules/ipykernel | |
| parent | tdlib: enable on darwin (diff) | |
| download | nixpkgs-899cf4ba29271b629cd621a421922ed2cb7eefc2.tar.gz | |
python3Packages.ipykernel: fix build on darwin
Also python34 is not supported:
https://github.com/ipython/ipykernel/commit/979e6fd2db9824934a89d97011d3f3eccc6d4499
nixpkgs doesn't provide python34 anymore, so pythonOlder "3.5" is always
true and can be removed.
(cherry picked from commit d35009ee63af7a43ae3ebe6367cd01c40012b83f)
cc #80940
Diffstat (limited to 'pkgs/development/python-modules/ipykernel')
| -rw-r--r-- | pkgs/development/python-modules/ipykernel/default.nix | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/pkgs/development/python-modules/ipykernel/default.nix b/pkgs/development/python-modules/ipykernel/default.nix index 6e356665d044..9c0ab175004e 100644 --- a/pkgs/development/python-modules/ipykernel/default.nix +++ b/pkgs/development/python-modules/ipykernel/default.nix @@ -16,7 +16,6 @@ buildPythonPackage rec { pname = "ipykernel"; version = "5.1.4"; - disabled = pythonOlder "3.4"; src = fetchPypi { inherit pname version; @@ -38,12 +37,23 @@ buildPythonPackage rec { preCheck = '' export HOME=$(mktemp -d) ''; - disabledTests = lib.optionals stdenv.isDarwin [ + disabledTests = lib.optionals stdenv.isDarwin ([ # see https://github.com/NixOS/nixpkgs/issues/76197 "test_subprocess_print" "test_subprocess_error" "test_ipython_start_kernel_no_userns" - ]; + ] ++ lib.optionals (pythonOlder "3.8") [ + # flaky test https://github.com/ipython/ipykernel/issues/485 + "test_shutdown" + + # test regression https://github.com/ipython/ipykernel/issues/486 + "test_sys_path_profile_dir" + "test_save_history" + "test_help_output" + "test_write_kernel_spec" + "test_ipython_start_kernel_userns" + "ZMQDisplayPublisherTests" + ]); # Some of the tests use localhost networking. __darwinAllowLocalNetworking = true; |