treewide: clean up 'meta = with' pattern

This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.

Co-authored-by: Wolfgang Walther <walther@technowledgy.de>

25 files changed, 93 insertions, 93 deletions

diff --git a/pkgs/games/cataclysm-dda/common.nix b/pkgs/games/cataclysm-dda/common.nix
index fa5091758d40..19eaf0f97f79 100644
--- a/pkgs/games/cataclysm-dda/common.nix
+++ b/pkgs/games/cataclysm-dda/common.nix
@@ -96,7 +96,7 @@ stdenv.mkDerivation {
     isCurses = !tiles;
   };
 
-  meta = with lib; {
+  meta = {
     description = "Free, post apocalyptic, zombie infested rogue-like";
     mainProgram = "cataclysm-tiles";
     longDescription = ''
@@ -123,11 +123,11 @@ stdenv.mkDerivation {
       than their original form.
     '';
     homepage = "https://cataclysmdda.org/";
-    license = licenses.cc-by-sa-30;
-    maintainers = with maintainers; [
+    license = lib.licenses.cc-by-sa-30;
+    maintainers = with lib.maintainers; [
       mnacamura
       DeeUnderscore
     ];
-    platforms = platforms.unix;
+    platforms = lib.platforms.unix;
   };
 }
diff --git a/pkgs/games/cataclysm-dda/pkgs/tilesets/UndeadPeople/default.nix b/pkgs/games/cataclysm-dda/pkgs/tilesets/UndeadPeople/default.nix
index 30c2793f6a8f..4b3039fbefb6 100644
--- a/pkgs/games/cataclysm-dda/pkgs/tilesets/UndeadPeople/default.nix
+++ b/pkgs/games/cataclysm-dda/pkgs/tilesets/UndeadPeople/default.nix
@@ -17,11 +17,11 @@ buildTileSet {
 
   modRoot = "MSX++UnDeadPeopleEdition";
 
-  meta = with lib; {
+  meta = {
     description = "Cataclysm DDA tileset based on MSX++ tileset";
     homepage = "https://github.com/jmz-b/UndeadPeopleTileset";
-    license = licenses.unfree;
-    maintainers = with maintainers; [ mnacamura ];
-    platforms = platforms.all;
+    license = lib.licenses.unfree;
+    maintainers = with lib.maintainers; [ mnacamura ];
+    platforms = lib.platforms.all;
   };
 }
diff --git a/pkgs/games/curseofwar/default.nix b/pkgs/games/curseofwar/default.nix
index 2bf91002024e..a6f411ca53ce 100644
--- a/pkgs/games/curseofwar/default.nix
+++ b/pkgs/games/curseofwar/default.nix
@@ -28,12 +28,12 @@ stdenv.mkDerivation (finalAttrs: {
     "CC=${stdenv.cc.targetPrefix}cc"
   ];
 
-  meta = with lib; {
+  meta = {
     description = "Fast-paced action strategy game";
     homepage = "https://a-nikolaev.github.io/curseofwar/";
-    license = licenses.gpl3;
+    license = lib.licenses.gpl3;
     mainProgram = if SDL != null then "curseofwar-sdl" else "curseofwar";
-    maintainers = with maintainers; [ fgaz ];
-    platforms = platforms.all;
+    maintainers = with lib.maintainers; [ fgaz ];
+    platforms = lib.platforms.all;
   };
 })
diff --git a/pkgs/games/duckmarines/default.nix b/pkgs/games/duckmarines/default.nix
index aaa32419cb7e..6f733132cde0 100644
--- a/pkgs/games/duckmarines/default.nix
+++ b/pkgs/games/duckmarines/default.nix
@@ -53,11 +53,11 @@ stdenv.mkDerivation rec {
     ln -s ${desktopItem}/share/applications/* $out/share/applications/
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Duck-themed action puzzle video game";
-    platforms = platforms.linux;
+    platforms = lib.platforms.linux;
     hydraPlatforms = [ ];
-    license = licenses.free;
+    license = lib.licenses.free;
     downloadPage = "http://tangramgames.dk/games/duckmarines";
   };
 
diff --git a/pkgs/games/dwarf-fortress/dwarf-therapist/default.nix b/pkgs/games/dwarf-fortress/dwarf-therapist/default.nix
index 75be441dd985..0973f5eb47e2 100644
--- a/pkgs/games/dwarf-fortress/dwarf-therapist/default.nix
+++ b/pkgs/games/dwarf-fortress/dwarf-therapist/default.nix
@@ -54,15 +54,15 @@ stdenv.mkDerivation rec {
     inherit maxDfVersion;
   };
 
-  meta = with lib; {
+  meta = {
     mainProgram = "dwarftherapist";
     description = "Tool to manage dwarves in a running game of Dwarf Fortress";
-    maintainers = with maintainers; [
+    maintainers = with lib.maintainers; [
       bendlas
       numinit
     ];
-    license = licenses.mit;
-    platforms = platforms.x86;
+    license = lib.licenses.mit;
+    platforms = lib.platforms.x86;
     homepage = "https://github.com/Dwarf-Therapist/Dwarf-Therapist";
   };
 }
diff --git a/pkgs/games/dwarf-fortress/legends-browser/default.nix b/pkgs/games/dwarf-fortress/legends-browser/default.nix
index a4aab7863c26..7d7d70589db2 100644
--- a/pkgs/games/dwarf-fortress/legends-browser/default.nix
+++ b/pkgs/games/dwarf-fortress/legends-browser/default.nix
@@ -32,15 +32,15 @@ buildEnv {
   inherit name;
   paths = [ script ];
 
-  meta = with lib; {
+  meta = {
     description = "Multi-platform, open source, java-based legends viewer for dwarf fortress";
-    maintainers = with maintainers; [
+    maintainers = with lib.maintainers; [
       Baughn
       numinit
     ];
-    sourceProvenance = with sourceTypes; [ binaryBytecode ];
-    license = licenses.mit;
-    platforms = platforms.all;
+    sourceProvenance = with lib.sourceTypes; [ binaryBytecode ];
+    license = lib.licenses.mit;
+    platforms = lib.platforms.all;
     homepage = "https://github.com/robertjanetzko/LegendsBrowser";
   };
 }
diff --git a/pkgs/games/fltrator/default.nix b/pkgs/games/fltrator/default.nix
index d1a39f76a130..63d80f7b34f2 100644
--- a/pkgs/games/fltrator/default.nix
+++ b/pkgs/games/fltrator/default.nix
@@ -49,16 +49,16 @@ stdenv.mkDerivation rec {
     cp rsc/fltrator-128.png $out/share/icons/hicolor/128x128/apps/fltrator2.png
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Simple retro style arcade side-scroller game";
     longDescription = ''
       FLTrator is a simple retro style arcade side-scroller game in which you steer a spaceship through a landscape with hostile rockets and other obstacles.
       It has ten different levels and a level editor to create new levels or modify the existing.
     ''; # from https://libregamewiki.org/FLTrator
     homepage = "https://fltrator.sourceforge.net/";
-    platforms = platforms.linux;
-    maintainers = [ maintainers.marius851000 ];
-    license = licenses.gpl3;
+    platforms = lib.platforms.linux;
+    maintainers = [ lib.maintainers.marius851000 ];
+    license = lib.licenses.gpl3;
   };
 
 }
diff --git a/pkgs/games/fteqw/generic.nix b/pkgs/games/fteqw/generic.nix
index 096638764764..a64fd05d9121 100644
--- a/pkgs/games/fteqw/generic.nix
+++ b/pkgs/games/fteqw/generic.nix
@@ -53,7 +53,7 @@ stdenv.mkDerivation {
     runHook postInstall
   '';
 
-  meta = with lib; {
+  meta = {
     inherit description;
     homepage = "https://fteqw.org";
     longDescription = ''
@@ -63,8 +63,8 @@ stdenv.mkDerivation {
       limits, vulkan and OpenGL renderers, a dedicated
       server, and fteqcc, for easier QuakeC development
     '';
-    maintainers = with maintainers; [ necrophcodr ];
-    license = licenses.gpl2Plus;
-    platforms = platforms.linux;
+    maintainers = with lib.maintainers; [ necrophcodr ];
+    license = lib.licenses.gpl2Plus;
+    platforms = lib.platforms.linux;
   };
 }
diff --git a/pkgs/games/gscrabble/default.nix b/pkgs/games/gscrabble/default.nix
index a262af977e68..fe4a5a0b8dd4 100644
--- a/pkgs/games/gscrabble/default.nix
+++ b/pkgs/games/gscrabble/default.nix
@@ -50,15 +50,15 @@ buildPythonApplication {
       )
   '';
 
-  meta = with lib; {
+  meta = {
     # Fails to build, probably incompatible with latest Python
     # error: Multiple top-level packages discovered in a flat-layout
     # https://github.com/RaaH/gscrabble/issues/13
     broken = true;
     description = "Golden Scrabble crossword puzzle game";
     homepage = "https://github.com/RaaH/gscrabble/";
-    license = licenses.gpl2Plus;
-    platforms = platforms.linux;
-    maintainers = with maintainers; [ onny ];
+    license = lib.licenses.gpl2Plus;
+    platforms = lib.platforms.linux;
+    maintainers = with lib.maintainers; [ onny ];
   };
 }
diff --git a/pkgs/games/liquidwar/5.nix b/pkgs/games/liquidwar/5.nix
index 65dbcc58b065..a39d316d767a 100644
--- a/pkgs/games/liquidwar/5.nix
+++ b/pkgs/games/liquidwar/5.nix
@@ -27,10 +27,10 @@ stdenv.mkDerivation rec {
     "-lm"
   ];
 
-  meta = with lib; {
+  meta = {
     description = "Classic version of a quick tactics game LiquidWar";
-    maintainers = [ maintainers.raskin ];
-    license = licenses.gpl2Plus;
-    platforms = platforms.linux;
+    maintainers = [ lib.maintainers.raskin ];
+    license = lib.licenses.gpl2Plus;
+    platforms = lib.platforms.linux;
   };
 }
diff --git a/pkgs/games/liquidwar/default.nix b/pkgs/games/liquidwar/default.nix
index c974c71ecd50..0ac6905c9f34 100644
--- a/pkgs/games/liquidwar/default.nix
+++ b/pkgs/games/liquidwar/default.nix
@@ -83,11 +83,11 @@ stdenv.mkDerivation rec {
   # To avoid problems finding SDL_types.h.
   configureFlags = [ "CFLAGS=-I${lib.getDev SDL}/include/SDL" ];
 
-  meta = with lib; {
+  meta = {
     description = "Quick tactics game";
     homepage = "https://www.gnu.org/software/liquidwar6/";
-    maintainers = [ maintainers.raskin ];
-    license = licenses.gpl3Plus;
-    platforms = platforms.linux;
+    maintainers = [ lib.maintainers.raskin ];
+    license = lib.licenses.gpl3Plus;
+    platforms = lib.platforms.linux;
   };
 }
diff --git a/pkgs/games/minecraft-servers/derivation.nix b/pkgs/games/minecraft-servers/derivation.nix
index 211d6ab02f37..4192dff1ccf6 100644
--- a/pkgs/games/minecraft-servers/derivation.nix
+++ b/pkgs/games/minecraft-servers/derivation.nix
@@ -39,13 +39,13 @@ stdenv.mkDerivation {
     updateScript = ./update.py;
   };
 
-  meta = with lib; {
+  meta = {
     description = "Minecraft Server";
     homepage = "https://minecraft.net";
-    sourceProvenance = with sourceTypes; [ binaryBytecode ];
-    license = licenses.unfreeRedistributable;
-    platforms = platforms.unix;
-    maintainers = with maintainers; [
+    sourceProvenance = with lib.sourceTypes; [ binaryBytecode ];
+    license = lib.licenses.unfreeRedistributable;
+    platforms = lib.platforms.unix;
+    maintainers = with lib.maintainers; [
       thoughtpolice
       tomberek
       costrouc
diff --git a/pkgs/games/openttd/grfcodec.nix b/pkgs/games/openttd/grfcodec.nix
index 584816769ef3..292fa0de4a7f 100644
--- a/pkgs/games/openttd/grfcodec.nix
+++ b/pkgs/games/openttd/grfcodec.nix
@@ -29,10 +29,10 @@ stdenv.mkDerivation {
     cp -a grfcodec grfid grfstrip nforenum $out/bin/
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Low-level (dis)assembler and linter for OpenTTD GRF files";
     homepage = "http://openttd.org/";
-    license = licenses.gpl2Plus;
-    maintainers = with maintainers; [ ToxicFrog ];
+    license = lib.licenses.gpl2Plus;
+    maintainers = with lib.maintainers; [ ToxicFrog ];
   };
 }
diff --git a/pkgs/games/openttd/nml.nix b/pkgs/games/openttd/nml.nix
index 77e0ee18a6bd..a0672b15e996 100644
--- a/pkgs/games/openttd/nml.nix
+++ b/pkgs/games/openttd/nml.nix
@@ -20,11 +20,11 @@ python3.pkgs.buildPythonApplication rec {
     pillow
   ];
 
-  meta = with lib; {
+  meta = {
     homepage = "http://openttdcoop.org/";
     description = "Compiler for OpenTTD NML files";
     mainProgram = "nmlc";
-    license = licenses.gpl2Plus;
-    maintainers = with maintainers; [ ToxicFrog ];
+    license = lib.licenses.gpl2Plus;
+    maintainers = with lib.maintainers; [ ToxicFrog ];
   };
 }
diff --git a/pkgs/games/openxray/default.nix b/pkgs/games/openxray/default.nix
index 563c12e02393..51579c472311 100644
--- a/pkgs/games/openxray/default.nix
+++ b/pkgs/games/openxray/default.nix
@@ -80,14 +80,14 @@ stdenv.mkDerivation (finalAttrs: {
 
   passthru.updateScript = gitUpdater { };
 
-  meta = with lib; {
+  meta = {
     mainProgram = "xr_3da";
     description = "Improved version of the X-Ray Engine, the game engine used in the world-famous S.T.A.L.K.E.R. game series by GSC Game World";
     homepage = "https://github.com/OpenXRay/xray-16/";
-    license = licenses.unfree // {
+    license = lib.licenses.unfree // {
       url = "https://github.com/OpenXRay/xray-16/blob/${finalAttrs.version}/License.txt";
     };
-    maintainers = with maintainers; [ OPNA2608 ];
+    maintainers = with lib.maintainers; [ OPNA2608 ];
     platforms = [
       "x86_64-linux"
       "i686-linux"
diff --git a/pkgs/games/pentobi/default.nix b/pkgs/games/pentobi/default.nix
index cbcddf570b03..657891db9af6 100644
--- a/pkgs/games/pentobi/default.nix
+++ b/pkgs/games/pentobi/default.nix
@@ -54,11 +54,11 @@ mkDerivation rec {
     "-DMETAINFO_ITS=${appstream}/share/gettext/its/metainfo.its"
   ];
 
-  meta = with lib; {
+  meta = {
     description = "Computer opponent for the board game Blokus";
     homepage = "https://pentobi.sourceforge.io";
-    license = licenses.gpl3Plus;
+    license = lib.licenses.gpl3Plus;
     maintainers = [ ];
-    platforms = platforms.linux;
+    platforms = lib.platforms.linux;
   };
 }
diff --git a/pkgs/games/pokerth/default.nix b/pkgs/games/pokerth/default.nix
index 5321d15eafff..9f2df261d8e2 100644
--- a/pkgs/games/pokerth/default.nix
+++ b/pkgs/games/pokerth/default.nix
@@ -87,12 +87,12 @@ mkDerivation rec {
 
   env.NIX_CFLAGS_COMPILE = "-I${lib.getDev SDL}/include/SDL";
 
-  meta = with lib; {
+  meta = {
     homepage = "https://www.pokerth.net";
     description = "Poker game ${target}";
     mainProgram = "pokerth";
-    license = licenses.gpl3;
-    maintainers = with maintainers; [ obadz ];
-    platforms = platforms.all;
+    license = lib.licenses.gpl3;
+    maintainers = with lib.maintainers; [ obadz ];
+    platforms = lib.platforms.all;
   };
 }
diff --git a/pkgs/games/quake2/yquake2/default.nix b/pkgs/games/quake2/yquake2/default.nix
index 1646cb3163c3..9f0999136ef0 100644
--- a/pkgs/games/quake2/yquake2/default.nix
+++ b/pkgs/games/quake2/yquake2/default.nix
@@ -92,12 +92,12 @@ let
       })
     ];
 
-    meta = with lib; {
+    meta = {
       description = "Yamagi Quake II client";
       homepage = "https://www.yamagi.org/quake2/";
-      license = licenses.gpl2Plus;
-      platforms = platforms.unix;
-      maintainers = with maintainers; [ tadfisher ];
+      license = lib.licenses.gpl2Plus;
+      platforms = lib.platforms.unix;
+      maintainers = with lib.maintainers; [ tadfisher ];
     };
   };
 
diff --git a/pkgs/games/quake2/yquake2/games.nix b/pkgs/games/quake2/yquake2/games.nix
index 2e1053eded72..86cd05f6c7d8 100644
--- a/pkgs/games/quake2/yquake2/games.nix
+++ b/pkgs/games/quake2/yquake2/games.nix
@@ -55,12 +55,12 @@ let
         runHook postInstall
       '';
 
-      meta = with lib; {
+      meta = {
         inherit (data) description;
         homepage = "https://www.yamagi.org/quake2/";
-        license = licenses.unfree;
-        platforms = platforms.unix;
-        maintainers = with maintainers; [ tadfisher ];
+        license = lib.licenses.unfree;
+        platforms = lib.platforms.unix;
+        maintainers = with lib.maintainers; [ tadfisher ];
       };
     };
 
diff --git a/pkgs/games/quake3/content/demo.nix b/pkgs/games/quake3/content/demo.nix
index 3edf3e76a6b1..dfcbbced56c0 100644
--- a/pkgs/games/quake3/content/demo.nix
+++ b/pkgs/games/quake3/content/demo.nix
@@ -25,7 +25,7 @@ stdenv.mkDerivation {
 
   preferLocalBuild = true;
 
-  meta = with lib; {
+  meta = {
     description = "Demo of Quake 3 Arena, a classic first-person shooter";
     longDescription = ''
       Quake III Arena and it's demo don't offer current wide screen resolutions in the menu.
@@ -39,8 +39,8 @@ stdenv.mkDerivation {
       $ quake3 +set r_mode -1 +set r_customwidth 2560 +set r_customheight 1440 +set r_fullscreen 1
     '';
     homepage = "https://www.idsoftware.com/";
-    license = licenses.unfreeRedistributable;
-    platforms = platforms.all;
+    license = lib.licenses.unfreeRedistributable;
+    platforms = lib.platforms.all;
     maintainers = [ ];
   };
 }
diff --git a/pkgs/games/quake3/content/hires.nix b/pkgs/games/quake3/content/hires.nix
index ec07228f03d1..85b9fe497bb8 100644
--- a/pkgs/games/quake3/content/hires.nix
+++ b/pkgs/games/quake3/content/hires.nix
@@ -65,10 +65,10 @@ stdenv.mkDerivation (finalAttrs: {
 
   preferLocalBuild = true;
 
-  meta = with lib; {
+  meta = {
     description = "Quake 3 high-resolution textures";
-    license = licenses.cc0;
-    platforms = platforms.all;
-    maintainers = with maintainers; [ rvolosatovs ];
+    license = lib.licenses.cc0;
+    platforms = lib.platforms.all;
+    maintainers = with lib.maintainers; [ rvolosatovs ];
   };
 })
diff --git a/pkgs/games/quake3/content/pointrelease.nix b/pkgs/games/quake3/content/pointrelease.nix
index 6eb81e2bc7ce..47790a738fce 100644
--- a/pkgs/games/quake3/content/pointrelease.nix
+++ b/pkgs/games/quake3/content/pointrelease.nix
@@ -25,10 +25,10 @@ stdenv.mkDerivation {
 
   preferLocalBuild = true;
 
-  meta = with lib; {
+  meta = {
     description = "Quake 3 Arena point release";
-    license = licenses.unfreeRedistributable;
-    platforms = platforms.all;
+    license = lib.licenses.unfreeRedistributable;
+    platforms = lib.platforms.all;
     maintainers = [ ];
   };
 }
diff --git a/pkgs/games/spring/springlobby.nix b/pkgs/games/spring/springlobby.nix
index c3194589ee26..e957a80bbd0e 100644
--- a/pkgs/games/spring/springlobby.nix
+++ b/pkgs/games/spring/springlobby.nix
@@ -68,11 +68,11 @@ stdenv.mkDerivation rec {
       --set SPRING_BUNDLE_DIR "${spring}/lib"
   '';
 
-  meta = with lib; {
+  meta = {
     homepage = "https://springlobby.springrts.com";
     description = "Cross-platform lobby client for the Spring RTS project";
-    license = licenses.gpl2Plus;
-    maintainers = with maintainers; [
+    license = lib.licenses.gpl2Plus;
+    maintainers = with lib.maintainers; [
       qknight
     ];
     platforms = [
diff --git a/pkgs/games/stuntrally/default.nix b/pkgs/games/stuntrally/default.nix
index 6f0590dd0e1a..656d4ca91510 100644
--- a/pkgs/games/stuntrally/default.nix
+++ b/pkgs/games/stuntrally/default.nix
@@ -83,11 +83,11 @@ stdenv.mkDerivation rec {
     tinyxml-2
   ];
 
-  meta = with lib; {
+  meta = {
     description = "Stunt Rally game with Track Editor, based on VDrift and OGRE";
     homepage = "http://stuntrally.tuxfamily.org/";
-    license = licenses.gpl3Plus;
-    maintainers = with maintainers; [ pSub ];
-    platforms = platforms.linux;
+    license = lib.licenses.gpl3Plus;
+    maintainers = with lib.maintainers; [ pSub ];
+    platforms = lib.platforms.linux;
   };
 }
diff --git a/pkgs/games/vessel/default.nix b/pkgs/games/vessel/default.nix
index 353f05a157d1..5de04c1de709 100644
--- a/pkgs/games/vessel/default.nix
+++ b/pkgs/games/vessel/default.nix
@@ -87,7 +87,7 @@ stdenv.mkDerivation rec {
     chmod +x $out/bin/Vessel
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Fluid physics based puzzle game";
     longDescription = ''
       Living liquid machines have overrun this world of unstoppable progress,
@@ -96,8 +96,8 @@ stdenv.mkDerivation rec {
       to life, and all the consequences that ensue.
     '';
     homepage = "http://www.strangeloopgames.com";
-    license = licenses.unfree;
-    maintainers = with maintainers; [ jcumming ];
+    license = lib.licenses.unfree;
+    maintainers = with lib.maintainers; [ jcumming ];
   };
 
 }