| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | Format: lib/fileset/internal.nix | Johannes Kirschbauer | 2025-02-12 | 1 | -2/+0 |
| * | Docs: migrate format of comments to doc-comments | Johannes Kirschbauer | 2025-02-12 | 1 | -4/+34 |
| * | treewide: format all inactive Nix files•••After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build https://github.com/infinisil/treewide-nixpkgs-reformat-script/archive/a08b3a4d199c6124ac5b36a889d9099b4383463f.tar.gz \
--argstr baseRev b32a0943687d2a5094a6d92f25a4b6e16a76b5b7
result/bin/apply-formatting $NIXPKGS_PATH
| Silvan Mosberger | 2024-12-10 | 1 | -140/+150 |
| * | lib.fileset.toList: init | Silvan Mosberger | 2024-02-26 | 1 | -0/+23 |
| * | lib.fileset.gitTracked: Allow clones of shallow repositories•••The only reason shallow clones are not the default in
`builtins.fetchGit` is that `revCount` can't be provided when cloning a
shallow repository. However, `revCount` isn't used or exposed by
`lib.fileset`. Hence, allowing cloning shallow repositories makes
`gitTracked` more general without any drawbacks.
Co-authored-by: Silvan Mosberger <github@infinisil.com>
| ibbem | 2024-02-01 | 1 | -1/+18 |
| * | lib.fileset.gitTracked: Support out-of-tree builds | Silvan Mosberger | 2023-12-19 | 1 | -3/+27 |
| * | lib.fileset.fetchGit: Refactoring | Silvan Mosberger | 2023-12-19 | 1 | -18/+24 |
| * | lib.fileset.gitTracked: Improve error when passing files | Silvan Mosberger | 2023-12-11 | 1 | -0/+2 |
| * | lib.fileset: Refactor gitTracked and gitTrackedWith•••Introduce an internal function for them to share more behavior.
This makes future changes easier.
| Silvan Mosberger | 2023-12-11 | 1 | -0/+31 |
| * | Merge pull request #266362 from tweag/fileset.fileFilter-ext•••`lib.fileset.fileFilter`: Predicate attribute for file extension | Silvan Mosberger | 2023-11-24 | 1 | -1/+4 |
| |\ |
|
| | * | lib.fileset.fileFilter: Predicate attribute for file extension | Silvan Mosberger | 2023-11-23 | 1 | -1/+4 |
| * | | lib.fileset.maybeMissing: init | Silvan Mosberger | 2023-11-20 | 1 | -1/+2 |
| |/ |
|
| * | lib.fileset: Minor changes•••- Make fromSource's missing file error message more consistent with others,
and add a test for it
- Indent some function arguments
- Fix an internal type
| Silvan Mosberger | 2023-11-19 | 1 | -4/+4 |
| * | lib.fileset.gitTrackedWith: Introduce recurseSubmodules parameter | Silvan Mosberger | 2023-11-16 | 1 | -0/+4 |
| * | lib.fileset.gitTracked/gitTrackedWith: init•••A configuration parameter for gitTrackedWith will be introduced in the
next commit
| Silvan Mosberger | 2023-11-16 | 1 | -0/+19 |
| * | lib.fileset.fileFilter: Restrict second argument to paths•••While this change is backwards-incompatible, I think it's okay because:
- The `fileFilter` function is not yet in a stable NixOS release, it was only merged about [a month ago](https://github.com/NixOS/nixpkgs/pull/257356).
- All public uses of the function on GitHub only pass a path
- Any `fileFilter pred fileset` can also be expressed as `intersection fileset (fileFilter pred path)` without loss of functionality.
- This is furthermore pointed out in the new error message when a file set is passed
| Silvan Mosberger | 2023-11-15 | 1 | -15/+18 |
| * | Merge pull request #267381 from tweag/fileset.fileFilter-path•••`fileset.fileFilter`: Don't run predicate unnecessarily | Silvan Mosberger | 2023-11-15 | 1 | -14/+25 |
| |\ |
|
| | * | lib.fileset.fileFilter: Don't run predicate unnecessarily•••Before:
nix-repl> fileset.trace (fileset.fileFilter (file: builtins.trace file.name false) ./default.nix)
trace: README.md
trace: benchmark.sh
trace: default.nix
trace: internal.nix
trace: mock-splitRoot.nix
trace: tests.sh
After:
nix-repl> fileset.trace (fileset.fileFilter (file: builtins.trace file.name false) ./default.nix)
trace: default.nix
| Silvan Mosberger | 2023-11-14 | 1 | -16/+23 |
| | * | lib.fileset.fileFilter: Minor cleanups and more tests | Silvan Mosberger | 2023-11-14 | 1 | -0/+4 |
| * | | Merge pull request #261732 from tweag/fileset.fromSource•••`lib.fileset.fromSource`: init | Robert Hensing | 2023-11-10 | 1 | -1/+59 |
| |\ \
| |/
|/| |
|
| | * | lib.fileset.toSource: Mention fromSource in errors | Silvan Mosberger | 2023-11-08 | 1 | -1/+6 |
| | * | lib.fileset.fromSource: init | Silvan Mosberger | 2023-11-08 | 1 | -0/+53 |
| * | | lib.fileset: Remove unused bindings•••Thanks nixd!
| Silvan Mosberger | 2023-11-09 | 1 | -3/+0 |
| * | | lib.fileset: Make error messages more uniform•••Just minor changes like:
- Always using "X is a Y, but it should be Z"
- "X is a path that does not exist" rather than "X does not exist"
- Always using multi-line strings for errors
- Always quoting string-like values and not quoting path-like values
- But do quote filesystem roots. Even though they're paths, they might
be very small, good to have quotes to know the start/end
- Capitalise the first word
- Distinguish root vs filesystem root more
| Silvan Mosberger | 2023-11-08 | 1 | -4/+4 |
| * | | Merge pull request #259065 from tweag/fileset.difference•••`lib.fileset.difference`: init | Silvan Mosberger | 2023-11-01 | 1 | -0/+80 |
| |\ \ |
|
| | * | | lib.fileset.difference: init | Silvan Mosberger | 2023-10-30 | 1 | -0/+80 |
| * | | | lib.fileset.toSource: Optimise unknown file type error•••Compared to the parent commit, this removes any detectable performance
cost :)
| Silvan Mosberger | 2023-10-30 | 1 | -27/+28 |
| * | | | lib.fileset.toSource: Improve error for unknown file types•••This does decrease performance unfortunately
Benchmarking expression toSource { root = ./.; fileset = ./.; }
Mean CPU time 0.103747 (σ = 0.012415) for 10 runs is 97.32181384964636% (σ = 16.34179537413021%) of the old value 0.106602 (σ = 0.0125571)
Statistic .envs.elements (205920) is 105.5842% (+10891) of the old value 195029
Statistic .gc.totalBytes (20247696) is 101.7495% (+348160) of the old value 19899536
Statistic .nrThunks (134824) is 108.7878% (+10891) of the old value 123933
Statistic .symbols.number (996) is 100.1005% (+1) of the old value 995
Statistic .values.number (275238) is 104.1199% (+10891) of the old value 264347
| Silvan Mosberger | 2023-10-30 | 1 | -19/+30 |
| |/ / |
|
| * / | lib.fileset.fileFilter: init | Silvan Mosberger | 2023-10-24 | 1 | -0/+26 |
| |/ |
|
| * | lib.fileset: Improved error for unsupported coercion values | Silvan Mosberger | 2023-10-16 | 1 | -2/+2 |
| * | lib.fileset.intersection: init | Silvan Mosberger | 2023-10-11 | 1 | -0/+93 |
| * | lib.fileset: Refactor for performance and future re-use | Silvan Mosberger | 2023-10-04 | 1 | -5/+17 |
| * | lib.fileset: Mention trace functions in the file set evaluation error | Silvan Mosberger | 2023-10-04 | 1 | -1/+3 |
| * | lib.fileset: Add internal helpers for pretty-printing | Silvan Mosberger | 2023-10-04 | 1 | -2/+107 |
| * | lib.fileset: _simplifyTree -> _normaliseTreeFilter | Silvan Mosberger | 2023-10-03 | 1 | -8/+8 |
| * | lib.fileset: Order noEval last | Silvan Mosberger | 2023-10-03 | 1 | -4/+8 |
| * | lib.fileset: Internal representation v3, empty value without a base•••`unions []` now works!
Notably the new empty value without a base is not exposed in the interface.
I don't know of any use case for it.
| Silvan Mosberger | 2023-10-03 | 1 | -13/+56 |
| * | lib.fileset: Minor changes from feedback•••Co-authored-by: Robert Hensing <robert@roberthensing.nl>
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
| Silvan Mosberger | 2023-09-21 | 1 | -6/+3 |
| * | lib.fileset: Internal representation v2, ~12x faster unions!••• $ ./benchmark.sh HEAD
[...]
Mean CPU time 0.04006 (σ = 0.0040146) for 10 runs is 8.193619775953792% (σ = 0.9584251052704821%) of the old value 0.488917 (σ = 0.0294955)
[...]
| Silvan Mosberger | 2023-09-21 | 1 | -40/+22 |
| * | lib.fileset.unions: Don't stack overflow for many files | Silvan Mosberger | 2023-09-21 | 1 | -39/+26 |
| * | lib.fileset.union: init | Silvan Mosberger | 2023-09-21 | 1 | -0/+113 |
| * | lib.fileset: Minor internal type doc fix | Silvan Mosberger | 2023-09-13 | 1 | -1/+1 |
| * | lib.fileset.toSource: Evaluate fileset even for empty directories | Silvan Mosberger | 2023-09-13 | 1 | -0/+1 |
| * | lib.fileset: Internal representation v1 | Silvan Mosberger | 2023-09-13 | 1 | -18/+46 |
| * | lib.fileset.toSource: init | Silvan Mosberger | 2023-09-01 | 1 | -0/+274 |
