| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | Store temporary traces on disk | Kamil Trzciński | 2019-04-25 | 1 | -1/+5 |
| * | Remove unnecessary log alias for logrus inport•••Some time ago [we had a discussion](https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/934#note_91891281)
about why we're aliasing some of the imports of `github.com/sirupsen/logrus`
package with a `log` alias.
At that moment we've been doing that in 17 from 68 cases when logrus
was imported in Runners codebase.
The conclusion was this aliasing is unnecessary, because:
- we relay on logrus interface so much that moving to another logging
library will be not so simple as switching the import name;
- we're totally not consistent in the alias usage which makes the code
even more messy.
Three GitLab Runner maintainers agreeded hat there is no reason to use
the aliasing and that we should just use `logrus` everywhere.
But no action was don since then. The cleanup was left for a future.
Unfortunately, because GitLab Runner is one of our biggest projects in
Go, for some people it becomes a source of suggestions of how certain
things should be handled. For example here is a discussion in a new
project that creates a go-based tool for our Serverless integration:
https://gitlab.com/gitlab-org/gitlabktl/merge_requests/9#note_152472275
The most important statement is:
> perhaps we could leave it as is since it is how we are exposing
logrus in the runner project
Because we already know that it should be changed and others start to
look on Runner's code to find good patterns, let's finally cleanup
the `log` aliasing mess.
| Tomasz Maczukin | 2019-03-21 | 1 | -15/+15 |
| * | Correct spelling of timed out in literals | Karl-Philipp Richter | 2019-02-17 | 1 | -1/+1 |
| * | Prevent Executors from modifying Runner configuration | St. John Johnson | 2019-01-23 | 1 | -2/+9 |
| * | Fix job duration counting | Tomasz Maczukin | 2018-09-26 | 1 | -7/+1 |
| * | CI Web Terminal | Francisco Javier López 🌴 On vacation; back on August 22th! | 2018-08-14 | 1 | -1/+1 |
| * | sed 's/Sirupsen\/logrus/sirupsen\/logrus/g' | Alessio Caiazza | 2018-02-23 | 1 | -1/+1 |
| * | Add NoneFailure reason | Tomasz Maczukin | 2017-12-18 | 1 | -1/+1 |
| * | Add failure_reason basic implementation | Shinya Maeda | 2017-12-18 | 1 | -1/+1 |
| * | Fix randomly failing test from commands/single_test.go | Tomasz Maczukin | 2017-09-13 | 1 | -13/+16 |
| * | Rename 2nd iteration: rename imports | Tomasz Maczukin | 2017-09-11 | 1 | -2/+2 |
| * | Refactor RunSingleCommand tests | Alessio Caiazza | 2017-08-22 | 1 | -4/+4 |
| * | Fix race condition in single runner | Alessio Caiazza | 2017-08-22 | 1 | -8/+9 |
| * | Swap codegangsta for urfave | Zeger-Jan van de Weg | 2017-08-22 | 1 | -1/+1 |
| * | Rename trace related code | Tomasz Maczukin | 2017-03-16 | 1 | -7/+7 |
| * | Rename BuildResponse and BuildRequest | Tomasz Maczukin | 2017-03-16 | 1 | -5/+5 |
| * | Rename common.BuildCredentials common.JobCredentials | Tomasz Maczukin | 2017-03-15 | 1 | -1/+1 |
| * | Use NewGitLabClient() instead of explicit GitLabClient{} | Tomasz Maczukin | 2017-03-15 | 1 | -1/+1 |
| * | Add a --max-builds option that will control the number of jobs a single runne...•••The default (zero) means that the runner will run forever.
Also implement a --wait-timeout option for the single executor, which if
non-zero, specifies how long the executor will wait between jobs.
Closes gitlab-org/gitlab-ci-multi-runner#1211
| Andrew Chin | 2016-12-20 | 1 | -4/+36 |
| * | Spelling corrections (codespell). | Dmitry Smirnov | 2016-08-05 | 1 | -1/+1 |
| * | Solve very rare case resulting in dead-lock when cancelling a build•••It's possible that we will block on Notify anonymous function, when the select loop a few lines below gets finished.
It will happen, because we use unbuffered channel, but don't have a possibility to consume it.
Thus this will block trace sending routing.
Trace sending routine will not finish, thus it will block trace.Success/Fail resulting in ability to cleanup a executor and releasing a machine.
This also renames BuildAbort to SystemInterrupt which is more accurate and makes a timeout a BuildError instead of SystemError.
| Kamil Trzcinski | 2016-07-17 | 1 | -1/+1 |
| * | Merge remote-tracking branch 'origin/master' into feature/incremental-trace-u... | Kamil Trzcinski | 2016-06-16 | 1 | -1/+1 |
| |\ |
|
| | * | Push runners in equal intervals to the workers queue | Kamil Trzcinski | 2016-06-15 | 1 | -1/+1 |
| * | | Replace common.GetBuildResponse with common.BuildCredentials in build processing | Tomasz Maczukin | 2016-06-08 | 1 | -1/+5 |
| * | | Add range handling at trace upload | Tomasz Maczukin | 2016-06-08 | 1 | -1/+1 |
| |/ |
|
| * | Remove the usage of Network in context of Build, Executor and Shell | Kamil Trzcinski | 2016-03-12 | 1 | -1/+0 |
| * | Fixes the #1078 | Kamil Trzcinski | 2016-02-29 | 1 | -1/+0 |
| * | Refactor build trace handling | Kamil Trzcinski | 2016-02-08 | 1 | -2/+7 |
| * | Introduce Acquire/Release to Executor•••- This allow to allocate resources in context of executor for time of fetching the builds
| Kamil Trzcinski | 2016-02-07 | 1 | -2/+14 |
| * | Reduce code complexity | Kamil Trzcinski | 2016-02-06 | 1 | -56/+65 |
| * | Fix segmentation fault | Kamil Trzcinski | 2015-11-21 | 1 | -0/+1 |
| * | Move network related code to separate class•••- Always use request body to send runner credentials
| Kamil Trzcinski | 2015-11-20 | 1 | -2/+6 |
| * | Fix compilation error | Kamil Trzcinski | 2015-08-23 | 1 | -1/+1 |
| * | Added support for SIGQUIT to allow to gracefully finish runner: runner will n... | Kamil Trzcinski | 2015-08-23 | 1 | -2/+9 |
| * | Update command line interface•••- Automatically provide command line options for all structure fields
- Make register expose all options
- Rewrite all other commands to use a new command processing scheme
| Kamil Trzcinski | 2015-08-18 | 1 | -106/+11 |
| * | Pass common.Config to Executor::Prepare | Kamil Trzcinski | 2015-07-11 | 1 | -1/+2 |
| * | Change github.com/ayufan/gitlab-ci-multi-runner to gitlab.com/gitlab-org/gitl... | Kamil Trzcinski | 2015-05-03 | 1 | -1/+1 |
| * | Make most of the config options optional | Kamil Trzcinski | 2015-04-29 | 1 | -2/+4 |
| * | Fixed critical concurrency issue | Kamil Trzcinski | 2015-04-01 | 1 | -2/+2 |
| * | Single-run mode handles now signals | Kamil Trzcinski | 2015-03-28 | 1 | -4/+44 |
| * | Use kardianos/service module | Kamil Trzcinski | 2015-03-27 | 1 | -8/+7 |
| * | Added default shell to single mode | Kamil Trzcinski | 2015-03-27 | 1 | -0/+7 |
| * | Make golint happy: consts | Kamil Trzcinski | 2015-03-20 | 1 | -1/+1 |
| * | Make golint happy: commands/ | Kamil Trzcinski | 2015-03-20 | 1 | -8/+8 |
| * | Abort all jobs if interrupt or SIGTERM is received | Kamil Trzcinski | 2015-03-12 | 1 | -1/+1 |
| * | Multi runner can run jobs on Heroku | Kamil Trzcinski | 2015-03-10 | 1 | -2/+79 |
| * | Fixed single builds | Kamil Trzcinski | 2015-03-10 | 1 | -0/+1 |
| * | Refactor sources | Kamil Trzcinski | 2015-02-12 | 1 | -0/+61 |
