| Commit message (Expand) | Author | Age | Files | Lines |
| * | Add test for <at> and <colon> masking | Zeff Morgan | 2019-08-05 | 1 | -4/+4 |
| * | Prevent running multiple instances of the gitlab-runner process using the sam... | Tomasz Maczukin | 2019-07-30 | 4 | -0/+212 |
| * | Fix some linting issues | Simon Jürgensmeyer | 2019-07-18 | 7 | -10/+20 |
| * | Merge branch '3356-disable-crashreport-for-docker-machine' into 'master'•••Force an opt-out from Docker Machine bugsnag report
Closes #3356
See merge request gitlab-org/gitlab-runner!1443 | Steve Azzopardi | 2019-07-17 | 2 | -14/+118 |
| |\ |
|
| | * | Use context.Background() to simplify the code | Tomasz Maczukin | 2019-07-16 | 1 | -6/+2 |
| | * | Respect user's configuration via environment variable | Tomasz Maczukin | 2019-07-12 | 2 | -14/+52 |
| | * | Force an opt-out from Docker Machine bugsnag report | Tomasz Maczukin | 2019-07-01 | 2 | -14/+84 |
| * | | Dynamically create information about authConfigs source•••(cherry picked from commit 6bff914ece7ee738d0831fdc2b5c2ea0f0245490) | Tomasz Maczukin | 2019-06-28 | 1 | -10/+12 |
| |/ |
|
| * | Merge branch 'cleanup' into 'master'•••Numerous typos were fixed. Some unused constants, variables and arguments were removed.
See merge request gitlab-org/gitlab-runner!1258 | Tomasz Maczukin | 2019-06-05 | 2 | -7/+5 |
| |\ |
|
| | * | Numerous typos were fixed. Some unused constants, variables and arguments wer... | Alexander Kutelev | 2019-03-25 | 2 | -7/+5 |
| * | | Merge branch 'docker-credentials-helper-support' into 'master'•••Docker Credentials helper support
See merge request gitlab-org/gitlab-runner!1386 | Tomasz Maczukin | 2019-06-05 | 1 | -2/+25 |
| |\ \ |
|
| | * | | After review commit | Andrei Burd | 2019-06-05 | 1 | -2/+6 |
| | * | | After @tmaczukin review•••Maintainer
| Andrei Burd | 2019-06-04 | 1 | -20/+11 |
| | * | | Docker Credentials helper support | Andrei Burd | 2019-05-29 | 1 | -0/+28 |
| * | | | Merge branch 'make-volumes-to-work-on-linux-docker-on-windows' into 'master'•••Make volumes to work on linux docker on windows
Closes #4251
See merge request gitlab-org/gitlab-runner!1363 | Tomasz Maczukin | 2019-06-01 | 5 | -0/+429 |
| |\ \ \ |
|
| | * | | | Make volumes to work on Linux Containers for Windows | Kamil Trzciński | 2019-05-29 | 5 | -0/+429 |
| | |/ / |
|
| * | | | Merge branch 'store-traces-on-disk' into 'master'•••Store traces on disk
See merge request gitlab-org/gitlab-runner!1315 | Tomasz Maczukin | 2019-05-31 | 2 | -54/+93 |
| |\ \ \
| |/ /
|/| | |
|
| | * | | Store temporary traces on disk | Kamil Trzciński | 2019-04-25 | 2 | -54/+93 |
| * | | | Remove usage of old helper image commands•••The bash scripts are deprecated and only used when someone specified a
`helper_image` in `[runners.docker]`. In 12.0 we are going to remove any support for the old
bash scripts in favor of the new Go commands.
The new Go commands were introduced for
https://gitlab.com/gitlab-org/gitlab-runner/issues/3755 for the
following merge requests:
- https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1195
- https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1201
- https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1218
Update `TestDockerCommandWithHelperImageConfig` to use one of the latest
image that has the new commands, since the tag that is being used does
not have the new commands which leads into a build failure.
closes https://gitlab.com/gitlab-org/gitlab-runner/issues/4013
| Steve Azzopardi | 2019-05-28 | 1 | -8/+0 |
| * | | | Merge branch '4073-remove-deprecated-k8s-entrypoint-ff' into 'master'•••Remove support for deprecated entrypoint configuration for K8S
Closes #4073
See merge request gitlab-org/gitlab-runner!1369 | Steve Azzopardi | 2019-05-28 | 1 | -8/+0 |
| |\ \ \ |
|
| | * | | | Remove support for deprecated entrypoint configuration for K8S | Tomasz Maczukin | 2019-05-27 | 1 | -8/+0 |
| * | | | | Remove deprecated git clone strategy | Tomasz Maczukin | 2019-05-23 | 1 | -8/+0 |
| |/ / / |
|
| * | | | Add UseLegacyVolumesMountingOrder feature flag | Tomasz Maczukin | 2019-05-23 | 1 | -0/+8 |
| * | | | Update mocks•••We again have some of our mocks not aligned with what mockery
autogenerates. This MR updates all affected **existing** mocks, so
calling `make mocks` will not have side effects in specific MRs.
| Tomasz Maczukin | 2019-05-06 | 1 | -0/+33 |
| * | | | Add support for PowerShell for helper image•••A default command is passed to the helper image container when it
starts, since it's specific to Linux it take in consideration which OS
is being used.
The helperimage package now also controls the command that are used by
default.
| Steve Azzopardi | 2019-05-04 | 5 | -0/+14 |
| * | | | Add test case for Linux helper image | Steve Azzopardi | 2019-04-25 | 1 | -0/+10 |
| * | | | Merge branch '4180-remove-legacy-build-directory-caching-update-deprecation-v...•••Change deprecation of FF_USE_LEGACY_BUILDS_DIR_FOR_DOCKER to 12.3
See merge request gitlab-org/gitlab-runner!1330 | Tomasz Maczukin | 2019-04-23 | 1 | -1/+1 |
| |\ \ \ |
|
| | * | | | Change deprecation of FF_USE_LEGACY_BUILDS_DIR_FOR_DOCKER to 12.3 | Steve Azzopardi | 2019-04-23 | 1 | -1/+1 |
| * | | | | Refactor helperimage tests•••- Use map[string]struct{} for tests with name
- Use consistent naming for table tests
- Use constant for windows supported architecture
closes https://gitlab.com/gitlab-org/gitlab-runner/issues/4179
| Steve Azzopardi | 2019-04-23 | 3 | -30/+26 |
| |/ / / |
|
| * | | | Merge branch '3896-refactor-helper-image-package' into 'master'•••Refactor Helper Image package to work with Kubernetes
See merge request gitlab-org/gitlab-runner!1306 | Tomasz Maczukin | 2019-04-23 | 6 | -113/+169 |
| |\ \ \ |
|
| | * | | | Refactor helper image revision check•••Both Docker and Kubernetes executor are checking what kind of revision
is being used so it can be used to pull in the right helper image,
extract that logic to `helperImage` package.
| Steve Azzopardi | 2019-04-23 | 2 | -2/+36 |
| | * | | | Refactor helpers/docker/helperimage package•••The helper image is being used for both Kubernetes and Docker executor.
But the code does not represent this, instead it duplicates the logic,
such as creating the Linux tag and the name of the image.
Refactor the helperimage package so that it can be used for both, by
removing specific structs from the docker API, by defining helperimage
own Config struct.
The need for the refactor is for
https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1243, because
we need to define different commands to run on the helper image, which
is located in `common/container.go` which needs to change depending on
the OS Type of docker, and we can't change it before we change how
Kubernetes uses the helper image.
| Steve Azzopardi | 2019-04-22 | 6 | -113/+135 |
| * | | | | Update documentation for legacy feature flags•••The feature flags disables the new code path not enabling it, the new
code path is enabled by default.
| Steve Azzopardi | 2019-04-22 | 1 | -2/+2 |
| * | | | | Format flags_test.go•••Remove some whitespace and order struct initialization
| Steve Azzopardi | 2019-04-22 | 1 | -4/+2 |
| |/ / / |
|
| * | | | Drop the 'FF' prefix from feature flag constants•••The constants are now defined inside of the 'featureflags' package,
so there is no need for the 'FF' prefix. The fact that it's a feature
flag is quite obvious when looking on an entry like:
IsFeatureFlagOn(featureflags.UseLegacyBuildsDirForDocker)
| Tomasz Maczukin | 2019-04-19 | 1 | -10/+10 |
| * | | | Generate table of FF in documentation automatically from the definitions | Tomasz Maczukin | 2019-04-19 | 1 | -0/+5 |
| * | | | Prepare single source of thruth for defined feature flags | Tomasz Maczukin | 2019-04-19 | 2 | -0/+142 |
| |/ / |
|
| * | | Extract unsupportedOSTypeError to errors pkg•••This error is going to be used in multiple places since we only support
a specific set of OS for docker.
| Steve Azzopardi | 2019-04-11 | 3 | -18/+28 |
| * | | Change to servercode tag instead of nanoserver•••Change the tag of the helper image to have servercore instead of
nanoserver since it was changed in
https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1290
reference https://gitlab.com/gitlab-org/gitlab-runner/issues/3896
| Steve Azzopardi | 2019-04-08 | 2 | -7/+7 |
| * | | Colored output failed on Windows machines - fixed now.•••GitLab Runner terminal output failed to output color codes on Windows machines. Instead, code gibberish was output.
This merge request fixes color output on Windows machines.
| Axel D | 2019-04-02 | 2 | -0/+32 |
| |/ |
|
| * | Merge branch 'remove-alias-for-logrus-imports' into 'master'•••Remove unnecessary log alias for logrus inport
See merge request gitlab-org/gitlab-runner!1256 | Steve Azzopardi | 2019-03-22 | 2 | -6/+7 |
| |\ |
|
| | * | Remove unnecessary log alias for logrus inport•••Some time ago [we had a discussion](https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/934#note_91891281)
about why we're aliasing some of the imports of `github.com/sirupsen/logrus`
package with a `log` alias.
At that moment we've been doing that in 17 from 68 cases when logrus
was imported in Runners codebase.
The conclusion was this aliasing is unnecessary, because:
- we relay on logrus interface so much that moving to another logging
library will be not so simple as switching the import name;
- we're totally not consistent in the alias usage which makes the code
even more messy.
Three GitLab Runner maintainers agreeded hat there is no reason to use
the aliasing and that we should just use `logrus` everywhere.
But no action was don since then. The cleanup was left for a future.
Unfortunately, because GitLab Runner is one of our biggest projects in
Go, for some people it becomes a source of suggestions of how certain
things should be handled. For example here is a discussion in a new
project that creates a go-based tool for our Serverless integration:
https://gitlab.com/gitlab-org/gitlabktl/merge_requests/9#note_152472275
The most important statement is:
> perhaps we could leave it as is since it is how we are exposing
logrus in the runner project
Because we already know that it should be changed and others start to
look on Runner's code to find good patterns, let's finally cleanup
the `log` aliasing mess.
| Tomasz Maczukin | 2019-03-21 | 2 | -6/+7 |
| * | | Refactor test not to be runtime dependent•••We are checking if the image tag is `x86_64-xxx` for any kind of runtime
the test is running, which is not true because if the test is run on arm
it would fail.
| Steve Azzopardi | 2019-03-21 | 1 | -1/+14 |
| * | | Check for windows server version with boundaries•••One day we can end up with a windows server version of `Windows Server
2019 Datacenter Evaluation Version 1809 (OS Build 18033.316)` which
would end up picking the wrong image since it would match the wrong
version.
regexp was not used to the sake of performance and to make thins a bit
simplier/more readable.
| Steve Azzopardi | 2019-03-21 | 2 | -1/+6 |
| * | | Move helperImageInfo to its own package | Tomasz Maczukin | 2019-03-20 | 6 | -0/+289 |
| |/ |
|
| * | Add ability to mask variables.•••This makes variables to be allowed to be `masked: true`.
The masked values will be replaced with `[MASKED]`.
The masking is done in-line, thus we delay sending trace
if the content is partial match for masked output.
| Kamil Trzciński | 2019-03-06 | 2 | -0/+215 |
| * | Update docker API to version 1.25•••Updating the docker API version will drop support for multiple docker
versions as shown in
https://docs.docker.com/develop/sdk/#api-version-matrix the most notable
one is centos6.
The rationale of the API version update is to start supporting Windows
Containers as part of https://gitlab.com/groups/gitlab-org/-/epics/535
| Steve Azzopardi | 2019-02-11 | 1 | -1/+1 |
| * | Fix breaking changes from docker client update•••Because of the `github.com/docker/docker` dependency update, there are
some breaking changes on the SDK itself, where an update to our internal
interface had to be made.
| Steve Azzopardi | 2019-02-08 | 3 | -10/+10 |
| * | Change dependency to github.com/docker/cli•••The docker cli was moved into it's own repository, in
https://github.com/docker/cli which not is the source of through for the
docker configuration.
https://gitlab.com/gitlab-org/gitlab-runner/issues/3488
| Steve Azzopardi | 2019-02-08 | 1 | -2/+2 |
| * | Merge branch 'remove-unsued-docker-client-funcs' into 'master'•••Remove ContainerWait from docker client
See merge request gitlab-org/gitlab-runner!1155 | Alessio Caiazza | 2019-01-25 | 3 | -28/+0 |
| |\ |
|