summaryrefslogtreecommitdiff
path: root/helpers (follow)
Commit message (Expand)AuthorAgeFilesLines
* Add test for <at> and <colon> maskingZeff Morgan2019-08-051-4/+4
* Prevent running multiple instances of the gitlab-runner process using the sam...Tomasz Maczukin2019-07-304-0/+212
* Fix some linting issuesSimon Jürgensmeyer2019-07-187-10/+20
* Merge branch '3356-disable-crashreport-for-docker-machine' into 'master'•••Force an opt-out from Docker Machine bugsnag report Closes #3356 See merge request gitlab-org/gitlab-runner!1443Steve Azzopardi2019-07-172-14/+118
|\
| * Use context.Background() to simplify the codeTomasz Maczukin2019-07-161-6/+2
| * Respect user's configuration via environment variableTomasz Maczukin2019-07-122-14/+52
| * Force an opt-out from Docker Machine bugsnag reportTomasz Maczukin2019-07-012-14/+84
* | Dynamically create information about authConfigs source•••(cherry picked from commit 6bff914ece7ee738d0831fdc2b5c2ea0f0245490)Tomasz Maczukin2019-06-281-10/+12
|/
* Merge branch 'cleanup' into 'master'•••Numerous typos were fixed. Some unused constants, variables and arguments were removed. See merge request gitlab-org/gitlab-runner!1258Tomasz Maczukin2019-06-052-7/+5
|\
| * Numerous typos were fixed. Some unused constants, variables and arguments wer...Alexander Kutelev2019-03-252-7/+5
* | Merge branch 'docker-credentials-helper-support' into 'master'•••Docker Credentials helper support See merge request gitlab-org/gitlab-runner!1386Tomasz Maczukin2019-06-051-2/+25
|\ \
| * | After review commitAndrei Burd2019-06-051-2/+6
| * | After @tmaczukin review•••Maintainer Andrei Burd2019-06-041-20/+11
| * | Docker Credentials helper supportAndrei Burd2019-05-291-0/+28
* | | Merge branch 'make-volumes-to-work-on-linux-docker-on-windows' into 'master'•••Make volumes to work on linux docker on windows Closes #4251 See merge request gitlab-org/gitlab-runner!1363Tomasz Maczukin2019-06-015-0/+429
|\ \ \
| * | | Make volumes to work on Linux Containers for WindowsKamil Trzciński2019-05-295-0/+429
| |/ /
* | | Merge branch 'store-traces-on-disk' into 'master'•••Store traces on disk See merge request gitlab-org/gitlab-runner!1315Tomasz Maczukin2019-05-312-54/+93
|\ \ \ | |/ / |/| |
| * | Store temporary traces on diskKamil Trzciński2019-04-252-54/+93
* | | Remove usage of old helper image commands•••The bash scripts are deprecated and only used when someone specified a `helper_image` in `[runners.docker]`. In 12.0 we are going to remove any support for the old bash scripts in favor of the new Go commands. The new Go commands were introduced for https://gitlab.com/gitlab-org/gitlab-runner/issues/3755 for the following merge requests: - https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1195 - https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1201 - https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1218 Update `TestDockerCommandWithHelperImageConfig` to use one of the latest image that has the new commands, since the tag that is being used does not have the new commands which leads into a build failure. closes https://gitlab.com/gitlab-org/gitlab-runner/issues/4013 Steve Azzopardi2019-05-281-8/+0
* | | Merge branch '4073-remove-deprecated-k8s-entrypoint-ff' into 'master'•••Remove support for deprecated entrypoint configuration for K8S Closes #4073 See merge request gitlab-org/gitlab-runner!1369Steve Azzopardi2019-05-281-8/+0
|\ \ \
| * | | Remove support for deprecated entrypoint configuration for K8STomasz Maczukin2019-05-271-8/+0
* | | | Remove deprecated git clone strategyTomasz Maczukin2019-05-231-8/+0
|/ / /
* | | Add UseLegacyVolumesMountingOrder feature flagTomasz Maczukin2019-05-231-0/+8
* | | Update mocks•••We again have some of our mocks not aligned with what mockery autogenerates. This MR updates all affected **existing** mocks, so calling `make mocks` will not have side effects in specific MRs. Tomasz Maczukin2019-05-061-0/+33
* | | Add support for PowerShell for helper image•••A default command is passed to the helper image container when it starts, since it's specific to Linux it take in consideration which OS is being used. The helperimage package now also controls the command that are used by default. Steve Azzopardi2019-05-045-0/+14
* | | Add test case for Linux helper imageSteve Azzopardi2019-04-251-0/+10
* | | Merge branch '4180-remove-legacy-build-directory-caching-update-deprecation-v...•••Change deprecation of FF_USE_LEGACY_BUILDS_DIR_FOR_DOCKER to 12.3 See merge request gitlab-org/gitlab-runner!1330Tomasz Maczukin2019-04-231-1/+1
|\ \ \
| * | | Change deprecation of FF_USE_LEGACY_BUILDS_DIR_FOR_DOCKER to 12.3Steve Azzopardi2019-04-231-1/+1
* | | | Refactor helperimage tests•••- Use map[string]struct{} for tests with name - Use consistent naming for table tests - Use constant for windows supported architecture closes https://gitlab.com/gitlab-org/gitlab-runner/issues/4179 Steve Azzopardi2019-04-233-30/+26
|/ / /
* | | Merge branch '3896-refactor-helper-image-package' into 'master'•••Refactor Helper Image package to work with Kubernetes See merge request gitlab-org/gitlab-runner!1306Tomasz Maczukin2019-04-236-113/+169
|\ \ \
| * | | Refactor helper image revision check•••Both Docker and Kubernetes executor are checking what kind of revision is being used so it can be used to pull in the right helper image, extract that logic to `helperImage` package. Steve Azzopardi2019-04-232-2/+36
| * | | Refactor helpers/docker/helperimage package•••The helper image is being used for both Kubernetes and Docker executor. But the code does not represent this, instead it duplicates the logic, such as creating the Linux tag and the name of the image. Refactor the helperimage package so that it can be used for both, by removing specific structs from the docker API, by defining helperimage own Config struct. The need for the refactor is for https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1243, because we need to define different commands to run on the helper image, which is located in `common/container.go` which needs to change depending on the OS Type of docker, and we can't change it before we change how Kubernetes uses the helper image. Steve Azzopardi2019-04-226-113/+135
* | | | Update documentation for legacy feature flags•••The feature flags disables the new code path not enabling it, the new code path is enabled by default. Steve Azzopardi2019-04-221-2/+2
* | | | Format flags_test.go•••Remove some whitespace and order struct initialization Steve Azzopardi2019-04-221-4/+2
|/ / /
* | | Drop the 'FF' prefix from feature flag constants•••The constants are now defined inside of the 'featureflags' package, so there is no need for the 'FF' prefix. The fact that it's a feature flag is quite obvious when looking on an entry like: IsFeatureFlagOn(featureflags.UseLegacyBuildsDirForDocker) Tomasz Maczukin2019-04-191-10/+10
* | | Generate table of FF in documentation automatically from the definitionsTomasz Maczukin2019-04-191-0/+5
* | | Prepare single source of thruth for defined feature flagsTomasz Maczukin2019-04-192-0/+142
|/ /
* | Extract unsupportedOSTypeError to errors pkg•••This error is going to be used in multiple places since we only support a specific set of OS for docker. Steve Azzopardi2019-04-113-18/+28
* | Change to servercode tag instead of nanoserver•••Change the tag of the helper image to have servercore instead of nanoserver since it was changed in https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1290 reference https://gitlab.com/gitlab-org/gitlab-runner/issues/3896 Steve Azzopardi2019-04-082-7/+7
* | Colored output failed on Windows machines - fixed now.•••GitLab Runner terminal output failed to output color codes on Windows machines. Instead, code gibberish was output. This merge request fixes color output on Windows machines. Axel D2019-04-022-0/+32
|/
* Merge branch 'remove-alias-for-logrus-imports' into 'master'•••Remove unnecessary log alias for logrus inport See merge request gitlab-org/gitlab-runner!1256Steve Azzopardi2019-03-222-6/+7
|\
| * Remove unnecessary log alias for logrus inport•••Some time ago [we had a discussion](https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/934#note_91891281) about why we're aliasing some of the imports of `github.com/sirupsen/logrus` package with a `log` alias. At that moment we've been doing that in 17 from 68 cases when logrus was imported in Runners codebase. The conclusion was this aliasing is unnecessary, because: - we relay on logrus interface so much that moving to another logging library will be not so simple as switching the import name; - we're totally not consistent in the alias usage which makes the code even more messy. Three GitLab Runner maintainers agreeded hat there is no reason to use the aliasing and that we should just use `logrus` everywhere. But no action was don since then. The cleanup was left for a future. Unfortunately, because GitLab Runner is one of our biggest projects in Go, for some people it becomes a source of suggestions of how certain things should be handled. For example here is a discussion in a new project that creates a go-based tool for our Serverless integration: https://gitlab.com/gitlab-org/gitlabktl/merge_requests/9#note_152472275 The most important statement is: > perhaps we could leave it as is since it is how we are exposing logrus in the runner project Because we already know that it should be changed and others start to look on Runner's code to find good patterns, let's finally cleanup the `log` aliasing mess. Tomasz Maczukin2019-03-212-6/+7
* | Refactor test not to be runtime dependent•••We are checking if the image tag is `x86_64-xxx` for any kind of runtime the test is running, which is not true because if the test is run on arm it would fail. Steve Azzopardi2019-03-211-1/+14
* | Check for windows server version with boundaries•••One day we can end up with a windows server version of `Windows Server 2019 Datacenter Evaluation Version 1809 (OS Build 18033.316)` which would end up picking the wrong image since it would match the wrong version. regexp was not used to the sake of performance and to make thins a bit simplier/more readable. Steve Azzopardi2019-03-212-1/+6
* | Move helperImageInfo to its own packageTomasz Maczukin2019-03-206-0/+289
|/
* Add ability to mask variables.•••This makes variables to be allowed to be `masked: true`. The masked values will be replaced with `[MASKED]`. The masking is done in-line, thus we delay sending trace if the content is partial match for masked output. Kamil Trzciński2019-03-062-0/+215
* Update docker API to version 1.25•••Updating the docker API version will drop support for multiple docker versions as shown in https://docs.docker.com/develop/sdk/#api-version-matrix the most notable one is centos6. The rationale of the API version update is to start supporting Windows Containers as part of https://gitlab.com/groups/gitlab-org/-/epics/535 Steve Azzopardi2019-02-111-1/+1
* Fix breaking changes from docker client update•••Because of the `github.com/docker/docker` dependency update, there are some breaking changes on the SDK itself, where an update to our internal interface had to be made. Steve Azzopardi2019-02-083-10/+10
* Change dependency to github.com/docker/cli•••The docker cli was moved into it's own repository, in https://github.com/docker/cli which not is the source of through for the docker configuration. https://gitlab.com/gitlab-org/gitlab-runner/issues/3488 Steve Azzopardi2019-02-081-2/+2
* Merge branch 'remove-unsued-docker-client-funcs' into 'master'•••Remove ContainerWait from docker client See merge request gitlab-org/gitlab-runner!1155Alessio Caiazza2019-01-253-28/+0
|\