1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
|
package commands
import (
"io/ioutil"
"os"
"sync"
"sync/atomic"
"testing"
"time"
"github.com/gofrs/flock"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitlab-runner/common"
"gitlab.com/gitlab-org/gitlab-runner/helpers"
)
func TestProcessRunner_BuildLimit(t *testing.T) {
cfg := common.RunnerConfig{
Limit: 2,
RequestConcurrency: 10,
RunnerSettings: common.RunnerSettings{
Executor: "multi-runner-build-limit",
},
}
jobData := common.JobResponse{
ID: 1,
Steps: []common.Step{
{
Name: "sleep",
Script: common.StepScript{"sleep 10"},
Timeout: 15,
When: "",
AllowFailure: false,
},
},
}
mJobTrace := common.MockJobTrace{}
defer mJobTrace.AssertExpectations(t)
mJobTrace.On("SetFailuresCollector", mock.Anything)
mJobTrace.On("Write", mock.Anything).Return(0, nil)
mJobTrace.On("IsStdout").Return(false)
mJobTrace.On("SetCancelFunc", mock.Anything)
mJobTrace.On("SetMasked", mock.Anything)
mJobTrace.On("Success")
mJobTrace.On("Fail", mock.Anything, mock.Anything)
mNetwork := common.MockNetwork{}
defer mNetwork.AssertExpectations(t)
mNetwork.On("RequestJob", mock.Anything, mock.Anything).Return(&jobData, true)
mNetwork.On("ProcessJob", mock.Anything, mock.Anything).Return(&mJobTrace, nil)
var runningBuilds uint32
e := common.MockExecutor{}
defer e.AssertExpectations(t)
e.On("Prepare", mock.Anything, mock.Anything, mock.Anything).Return(nil)
e.On("Cleanup").Maybe().Return()
e.On("Shell").Return(&common.ShellScriptInfo{Shell: "script-shell"})
e.On("Finish", mock.Anything).Return(nil).Maybe()
e.On("Run", mock.Anything).Run(func(args mock.Arguments) {
atomic.AddUint32(&runningBuilds, 1)
// Simulate work to fill up build queue.
time.Sleep(1 * time.Second)
}).Return(nil)
p := common.MockExecutorProvider{}
defer p.AssertExpectations(t)
p.On("Acquire", mock.Anything).Return(nil, nil)
p.On("Release", mock.Anything, mock.Anything).Return(nil).Maybe()
p.On("CanCreate").Return(true).Once()
p.On("GetDefaultShell").Return("bash").Once()
p.On("GetFeatures", mock.Anything).Return(nil)
p.On("Create").Return(&e)
common.RegisterExecutor("multi-runner-build-limit", &p)
cmd := RunCommand{
network: &mNetwork,
buildsHelper: newBuildsHelper(),
configOptionsWithListenAddress: configOptionsWithListenAddress{
configOptions: configOptions{
config: &common.Config{
User: "git",
},
},
},
}
runners := make(chan *common.RunnerConfig)
// Start 2 builds.
wg := sync.WaitGroup{}
wg.Add(2)
for i := 0; i < 2; i++ {
go func(i int) {
defer wg.Done()
err := cmd.processRunner(i, &cfg, runners)
assert.NoError(t, err)
}(i)
}
// Wait until at least two builds have started.
for atomic.LoadUint32(&runningBuilds) < 2 {
time.Sleep(10 * time.Millisecond)
}
err := cmd.processRunner(3, &cfg, runners)
assert.EqualError(t, err, "failed to request job, runner limit met")
// Wait for all builds to finish.
wg.Wait()
}
func runFileLockingCmd(t *testing.T, wg *sync.WaitGroup, started chan bool, stop chan bool, filePath string, shouldPanic bool) {
cmd := &RunCommand{
configOptionsWithListenAddress: configOptionsWithListenAddress{
configOptions: configOptions{
ConfigFile: filePath,
config: &common.Config{
Concurrent: 5,
},
},
},
stopSignals: make(chan os.Signal),
reloadSignal: make(chan os.Signal, 1),
runFinished: make(chan bool, 1),
}
go func() {
if shouldPanic {
assert.Panics(t, cmd.RunWithLock, "Expected the Runner to create a new lock")
} else {
assert.NotPanics(t, cmd.RunWithLock, "Expected the Runner to reject creating a new lock")
}
wg.Done()
}()
close(started)
<-stop
cmd.stopSignal = os.Kill
}
func TestMulti_RunWithLock(t *testing.T) {
defer helpers.MakeFatalToPanic()()
file, err := ioutil.TempFile("", "config.toml")
require.NoError(t, err)
err = file.Close()
require.NoError(t, err)
filePath := file.Name()
wg := new(sync.WaitGroup)
stop := make(chan bool)
wg.Add(2)
started := make(chan bool)
go runFileLockingCmd(t, wg, started, stop, filePath, false)
<-started
time.Sleep(1 * time.Second)
started = make(chan bool)
go runFileLockingCmd(t, wg, started, stop, filePath, true)
<-started
time.Sleep(1 * time.Second)
close(stop)
wg.Wait()
// Try to lock the file to check if it was properly unlocked while
// finishing cmd.RunWithLock() call
fl := flock.New(filePath)
locked, err := fl.TryLock()
defer fl.Unlock()
assert.True(t, locked, "File was not unlocked!")
assert.NoError(t, err)
}
|
