1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
|
package common
import (
"bytes"
"context"
"testing"
"github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"
)
type fakeJobTrace struct {
buffer *bytes.Buffer
}
func (fjt *fakeJobTrace) Success() {}
func (fjt *fakeJobTrace) Fail(err error, failureReason JobFailureReason) {}
func (fjt *fakeJobTrace) SetCancelFunc(cancelFunc context.CancelFunc) {}
func (fjt *fakeJobTrace) SetFailuresCollector(fc FailuresCollector) {}
func (fjt *fakeJobTrace) SetMasked(masked []string) {}
func (fjt *fakeJobTrace) IsStdout() bool { return false }
func (fjt *fakeJobTrace) Write(p []byte) (n int, err error) {
return fjt.buffer.Write(p)
}
func (fjt *fakeJobTrace) Read() string {
return fjt.buffer.String()
}
func newFakeJobTrace() *fakeJobTrace {
fjt := &fakeJobTrace{
buffer: bytes.NewBuffer([]byte{}),
}
return fjt
}
func newBuildLogger(testName string, jt JobTrace) BuildLogger {
return BuildLogger{
log: jt,
entry: logrus.WithField("test", testName),
}
}
func runOnHijackedLogrusOutput(t *testing.T, handler func(t *testing.T, output *bytes.Buffer)) {
oldOutput := logrus.StandardLogger().Out
defer func() { logrus.StandardLogger().Out = oldOutput }()
buf := bytes.NewBuffer([]byte{})
logrus.StandardLogger().Out = buf
handler(t, buf)
}
func TestLogLineWithoutSecret(t *testing.T) {
runOnHijackedLogrusOutput(t, func(t *testing.T, output *bytes.Buffer) {
jt := newFakeJobTrace()
l := newBuildLogger("log-line-without-secret", jt)
l.Errorln("Fatal: Get http://localhost/?id=123")
assert.Contains(t, jt.Read(), `Get http://localhost/?id=123`)
assert.Contains(t, output.String(), `Get http://localhost/?id=123`)
})
}
func TestLogLineWithSecret(t *testing.T) {
runOnHijackedLogrusOutput(t, func(t *testing.T, output *bytes.Buffer) {
jt := newFakeJobTrace()
l := newBuildLogger("log-line-with-secret", jt)
l.Errorln("Get http://localhost/?id=123&X-Amz-Signature=abcd1234&private_token=abcd1234")
assert.Contains(t, jt.Read(), `Get http://localhost/?id=123&X-Amz-Signature=[FILTERED]&private_token=[FILTERED]`)
assert.Contains(t, output.String(), `Get http://localhost/?id=123&X-Amz-Signature=abcd1234&private_token=abcd1234`)
})
}
|
